]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_stat_activity: show NULL stmt start time for walsenders
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
commitfce9ba8192b48d7b4a57a19d92044c4f378a41a0
tree3dd4760f1e58e5479e45b7cc7bb4f3d6343a5f1a
parentb89845267a6b0197e86b5a189d26f90f6a45c05f
pg_stat_activity: show NULL stmt start time for walsenders

Returning a non-NULL time is pointless, sinc a walsender is not a
process that would be running normal transactions anyway, but the code
was unintentionally exposing the process start time intermittently,
which was not only bogus but it also confused monitoring systems looking
for idle transactions.  Fix by avoiding all updates in walsenders.

Backpatch to 11, where walsenders started appearing in pg_stat_activity.

Reported-by: Tomas Vondra
Discussion: https://postgr.es/m/20191209234409.exe7osmyalwkt5j4@development
src/backend/access/transam/xact.c