]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Pass qemuCaps to qemuDomainSaveImageOpen
authorJiri Denemark <jdenemar@redhat.com>
Mon, 5 Aug 2019 14:40:19 +0000 (16:40 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 9 Aug 2019 11:55:54 +0000 (13:55 +0200)
commitfd60aefec7f49d1053efdd5119db494bb474aeec
tree7da8263e2be37c282cb9e0ffe92fd4e10c5e8ced
parent900c5952499fb233a9c0d2e6d0a5fde84a99cf72
qemu: Pass qemuCaps to qemuDomainSaveImageOpen

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make
sure it gets the capabilities stored in the domain's private data if the
domain is running. Passing NULL may cause QEMU capabilities probing to
be triggered in case QEMU binary changed in the meantime. When this
happens while a running domain object is locked, QMP event delivered to
the domain before QEMU capabilities probing finishes will deadlock the
event loop.

This patch fixes all paths leading to qemuDomainSaveImageOpen.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c