]> git.ipfire.org Git - thirdparty/iptables.git/commit
xtoptions: fill in fallback value for nvals
authorJan Engelhardt <jengelh@medozas.de>
Sat, 27 Aug 2011 15:59:52 +0000 (17:59 +0200)
committerJan Engelhardt <jengelh@medozas.de>
Sat, 27 Aug 2011 16:36:12 +0000 (18:36 +0200)
commitfdb2a27825e558393fb715374c07873830d4d149
tree8c5cceb56cb199013147609e818f132539100ccf
parentdebcf48f6a72914a9c06e99b175ad64ef1f6f1cb
xtoptions: fill in fallback value for nvals

Parsing for libxt_conntrack rev 2 is done by using rev 2's option
structure, which specifies XTTYPE_PORT, and using rev 3's parser
skeleton, which uses cb->nvals. Reading cb->nvals when not using
XTTYPE_PORTRC (or any other multi-value type) is undefined behavior.

Make it defined. Since XTTYPE_NONE is the only type that can take
void, nvals logically ought to be 1.

References: http://marc.info/?l=netfilter-devel&m=131370592105298&w=2
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
iptables/xtoptions.c