]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: command: wire up usage of q35/ich9 disable s3/s4
authorCole Robinson <crobinso@redhat.com>
Sat, 9 Jan 2016 21:00:01 +0000 (16:00 -0500)
committerCole Robinson <crobinso@redhat.com>
Sun, 10 Jan 2016 20:16:38 +0000 (15:16 -0500)
commitfde937bda044b0a1aa2244a00d0b449d99758e25
tree37d648eb9b02a43e4bc4fb12e92d3e75d7f8f1f1
parentc77fd89000a756b93a0b2087c1e541e698850094
qemu: command: wire up usage of q35/ich9 disable s3/s4

If the q35 specific disable s3/s4 setting isn't supported, fallback to
specifying the PIIX setting, which is the previous behavior. It doesn't
have any effect, but qemu will just warn about it rather than error:

  qemu-system-x86_64: Warning: global PIIX4_PM.disable_s3=1 not used
  qemu-system-x86_64: Warning: global PIIX4_PM.disable_s4=1 not used

Since it doesn't error, I don't think we should either, since there
may be configs in the wild that already have q35 + disable_s3/4 (via
virt-manager)
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable-fallback.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable-fallback.xml [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c