]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scripts/dtc: dtx_diff: remove broken example from help text
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Thu, 13 Jan 2022 08:19:18 +0000 (09:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:33 +0000 (09:04 +0100)
commitfe02c43440d2ff26e33c523b3908c56ceae35390
treed19909c8df6a9058e8654b7fadc2bb5901c6e13c
parentf5578b6f4f91f7cb4031f3dcca6a6b64df2c786b
scripts/dtc: dtx_diff: remove broken example from help text

commit d8adf5b92a9d2205620874d498c39923ecea8749 upstream.

dtx_diff suggests to use <(...) syntax to pipe two inputs into it, but
this has never worked: The /proc/self/fds/... paths passed by the shell
will fail the `[ -f "${dtx}" ] && [ -r "${dtx}" ]` check in compile_to_dts,
but even with this check removed, the function cannot work: hexdump will
eat up the DTB magic, making the subsequent dtc call fail, as a pipe
cannot be rewound.

Simply remove this broken example, as there is already an alternative one
that works fine.

Fixes: 10eadc253ddf ("dtc: create tool to diff device trees")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220113081918.10387-1-matthias.schiffer@ew.tq-group.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
scripts/dtc/dtx_diff