]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: fix offset overflow on 32-bit archs in ext4_iomap_begin()
authorJiri Slaby <jslaby@suse.cz>
Thu, 22 Mar 2018 15:50:26 +0000 (11:50 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 22 Mar 2018 15:50:26 +0000 (11:50 -0400)
commitfe23cb65c2c394ea306f3714a17d46ab2e6a0af1
tree2dd4d16379134f12cadd81d8253cef75d2c57265
parent45d8ec4d9fd5468c08f2ef0b2b132bb62dc81a3d
ext4: fix offset overflow on 32-bit archs in ext4_iomap_begin()

ext4_iomap_begin() has a bug where offset returned in the iomap
structure will be truncated to unsigned long size. On 64-bit
architectures this is fine but on 32-bit architectures obviously not.
Not many places actually use the offset stored in the iomap structure
but one of visible failures is in SEEK_HOLE / SEEK_DATA implementation.
If we create a file like:

dd if=/dev/urandom of=file bs=1k seek=8m count=1

then

lseek64("file", 0x100000000ULL, SEEK_DATA)

wrongly returns 0x100000000 on unfixed kernel while it should return
0x200000000. Avoid the overflow by proper type cast.

Fixes: 545052e9e35a ("ext4: Switch to iomap for SEEK_HOLE / SEEK_DATA")
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org # v4.15
fs/ext4/inode.c