]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix mis-rounding and overflow hazards in date_bin().
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 28 Feb 2024 19:00:30 +0000 (14:00 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 28 Feb 2024 19:00:30 +0000 (14:00 -0500)
commitfe3b1b575e24748ddb9b3b67394fa10c279090ac
tree2f237bfcf6553b6d5552033b75aeed1ab16a08de
parent09f09884c18d725db7a60e03a8f78bafdbc78b95
Fix mis-rounding and overflow hazards in date_bin().

In the case where the target timestamp is before the origin timestamp
and their difference is already an exact multiple of the stride, the
code incorrectly subtracted the stride anyway.

Also detect several integer-overflow cases that previously produced
bogus results.  (The submitted patch tried to avoid overflow, but
I'm not convinced it's right, and problematic cases are so far out of
the plausibly-useful range that they don't seem worth sweating over.
Let's just use overflow-detecting arithmetic and throw errors.)

timestamp_bin() and timestamptz_bin() are basically identical and
so had identical bugs.  Fix both.

Report and patch by Moaaz Assali, adjusted some by me.  Back-patch
to v14 where date_bin() was introduced.

Discussion: https://postgr.es/m/CALkF+nvtuas-2kydG-WfofbRSJpyODAJWun==W-yO5j2R4meqA@mail.gmail.com
src/backend/utils/adt/timestamp.c
src/test/regress/expected/timestamp.out
src/test/regress/expected/timestamptz.out
src/test/regress/sql/timestamp.sql
src/test/regress/sql/timestamptz.sql