]> git.ipfire.org Git - thirdparty/qemu.git/commit
tests/qtest/libqtest.c: Check for g_setenv() failure
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 25 Mar 2024 10:41:01 +0000 (10:41 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 25 Mar 2024 14:17:07 +0000 (14:17 +0000)
commitfe3e38390126c2202292911c49d46fc7ee4a163a
tree0da2366e354527e9d50e6026d595a856a5bfd113
parent43199b13938aa693b2f10d8d17c59eebfe4e40c5
tests/qtest/libqtest.c: Check for g_setenv() failure

Coverity points out that g_setenv() can fail and we don't
check for this in qtest_inproc_init(). In practice this will
only fail if a memory allocation failed in setenv() or if
the caller passed an invalid architecture name (e.g. one
with an '=' in it), so rather than requiring the callsite
to check for failure, make g_setenv() failure fatal here,
similarly to what we did in commit aca68d95c515.

Resolves: Coverity CID 1497485
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240312183810.557768-8-peter.maydell@linaro.org
tests/qtest/libqtest.c