]> git.ipfire.org Git - thirdparty/qemu.git/commit
xenfb: avoid reading twice the same fields from the shared page
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:10:09 +0000 (15:10 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 15 Mar 2016 17:20:35 +0000 (12:20 -0500)
commitff083d3c3bc3e3e0194a8d1bd0419121edc054fc
tree57d3d22e73d1bf5f3df52c3bb9e034528f240776
parent4d59e78dfe6c1df181b54ee90f273de7d4cdfe86
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
(cherry picked from commit 7ea11bf376aea4bf8340eb363de9777c7f93e556)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/display/xenfb.c