]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration/block: fix pending() return value
authorVladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
Tue, 30 Dec 2014 10:04:16 +0000 (13:04 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 14 Jan 2015 23:08:44 +0000 (17:08 -0600)
commitff2fff621187080a83f7685183592f152f724a9c
treea439da58c2f128609910a42c6a5bfe8de2851919
parent83a66746c09f7737da1c17423bc82457ac29680f
migration/block: fix pending() return value

Because of wrong return value of .save_live_pending() in
migration/block.c, migration finishes before the whole disk is
transferred. Such situation occurs when the migration process is fast
enough, for example when source and dest are on the same host.

If in the bulk phase we return something < max_size, we will skip
transferring the tail of the device. Currently we have "set pending to
BLOCK_SIZE if it is zero" for bulk phase, but there no guarantee, that
it will be < max_size.

True approach is to return, for example, max_size+1 when we are in the
bulk phase.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
Message-id: 1419933856-4018-2-git-send-email-vsementsov@parallels.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit 04636dc410b163c2243e66c3813dd4900a50a4ed)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block-migration.c