]> git.ipfire.org Git - thirdparty/linux.git/commit
media: atomisp: Fix eed1_8 code assigning signed values to an unsigned variable
authorHans de Goede <hdegoede@redhat.com>
Sat, 7 Sep 2024 11:17:01 +0000 (13:17 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 10 Sep 2024 05:29:44 +0000 (07:29 +0200)
commitffe3dc5acaa2477276011d6eb61373220217cd9d
tree4778ef6e5f45444e6ecf5366ba20ea5d530da397
parentb36c41c51e9d763393634359b90f02414ef470a3
media: atomisp: Fix eed1_8 code assigning signed values to an unsigned variable

ia_css_eed1_8_vmem_encode() is assigning values with a range of -8192 -
8191 to e_dew_enh_y and e_dew_enh_a both of which are of the VMEM_ARRAY
type which maps to u16.

This causes the following smatch warnings:

drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c: drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c:177 ia_css_eed1_8_vmem_encode() warn: assigning (-8192) to unsigned variable 'to->e_dew_enh_y[0][base + j]'
drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c: drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c:182 ia_css_eed1_8_vmem_encode() warn: assigning (-8192) to unsigned variable 'to->e_dew_enh_a[0][base + j]'

Convert the e_dew_enh_y and e_dew_enh_a arrays to a new SVMEM_ARRAY type
which maps to s16 to fix this.

Link: https://lore.kernel.org/linux-media/20240907111701.8493-1-hdegoede@redhat.com
Reported-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Closes: https://lore.kernel.org/linux-media/20240906081542.5cb0c142@foz.lan/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem_local.h
drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8_param.h