]> git.ipfire.org Git - thirdparty/samba.git/commit
ctdb-scripts: Avoid failing updateip when IP is not assigned v4-21-test
authorMartin Schwenke <mschwenke@ddn.com>
Thu, 16 Oct 2025 02:54:22 +0000 (13:54 +1100)
committerJule Anger <janger@samba.org>
Wed, 22 Oct 2025 11:16:15 +0000 (11:16 +0000)
commit93152dcbc7d1ada4323c535cbf5b05d9bb5f1064
tree7163908d8d0dd6aa1411d5a04d26387a6548687a
parent604e1ab09c6a187eabf016a877dc73f1f948ccab
ctdb-scripts: Avoid failing updateip when IP is not assigned

There is no use failing this when it could behave more like takeip.

Use old interface of "__none__" as a hint that ctdbd doesn't think the
IP is assigned either.  In this case print a warning instead of an
error.  Take some care to avoid spurious errors in updateip.

After commit 0536d7a98b832fc00d26b09c26bf14fb63dbf5fb (which improves
IP address state checking), this will almost certainly not occur on
platforms with getifaddrs(3) (e.g. Linux).  This means it is only
likely to occur in 4.21 when net.ipv4.ip_nonlocal_bind=1.

Update test to match.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15935

Reported-by: Bailey Allison <ballison@45drives.com>
Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Fri Oct 17 06:28:30 UTC 2025 on atb-devel-224

(cherry picked from commit 0e73781bf84a1e8e596d8be3f55eeb5f8f927990)

Autobuild-User(v4-21-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-21-test): Wed Oct 22 11:16:15 UTC 2025 on atb-devel-224
ctdb/config/events/legacy/10.interface.script
ctdb/tests/UNIT/eventscripts/10.interface.updateip.001.sh