]> git.ipfire.org Git - thirdparty/openwrt.git/commit
realtek: RTL838x: remove artifical mdio delays 19901/head
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Fri, 29 Aug 2025 17:45:51 +0000 (13:45 -0400)
committerRobert Marko <robimarko@gmail.com>
Mon, 1 Sep 2025 08:48:09 +0000 (10:48 +0200)
commit0008b4ed073ed38271ce59f96a259f7a48189b5e
treed530fe5583b50b3786801f5ecefcf05d11442a65
parent1c92e468d544db98018c55d5d18e41fc1a3af20b
realtek: RTL838x: remove artifical mdio delays

For some reason 3 of the 4 mdio access functions contain an
artifical delay of 10ms. While it might have been part of
older Realtek SDKs it can no longer be found in current ones.
Remove the delays.

While we are here remove the pre-access bus ready checks.
It is sufficient to run them after the command start. If
anything fails the caller will get an error. This is the
same behaviour as for the other targets.

Finally cleanup the error handling. Something like this makes
no sense at all.

  err = rtmdio_838x_smi_wait_op(100000);
  if (err)
    goto errout;
  err = 0;
errout:

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/19901
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c