]> git.ipfire.org Git - thirdparty/zstd.git/commit
Do not test WIN32, instead test _WIN32 3772/head
authorDimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Sat, 23 Sep 2023 17:03:18 +0000 (19:03 +0200)
committerDimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Sat, 23 Sep 2023 17:03:18 +0000 (19:03 +0200)
commit585aaa0ed324a858226908fc1f00d78ed92b0f4b
tree1d41411301cb8d7ca87c984b98c2abcc51b7e8bd
parentcdceb0fce59785c841bf697e00067163106064e1
Do not test WIN32, instead test _WIN32

To the best of my knowledge:
* `_WIN32` and `_WIN64` are defined by the compiler,
* `WIN32` and `WIN64` are defined by the user, to indicate whatever
  the user chooses them to indicate. They mean 32-bit and 64-bit Windows
  compilation by convention only.

See:
https://accu.org/journals/overload/24/132/wilson_2223/

Windows compilers in general, and MSVC in particular, have been defining
`_WIN32` and `_WIN64` for a long time, provably at least since Visual Studio
2015, and in practice as early as in the days of 16-bit Windows.

See:
https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-140
https://learn.microsoft.com/en-us/windows/win32/winprog64/the-tools

Tests used to be inconsistent, sometimes testing `_WIN32`, sometimes
`_WIN32` and `WIN32`. This brings consistency to Windows detection.
contrib/seekable_format/examples/parallel_processing.c
programs/fileio.c
programs/platform.h
programs/util.h
zlibWrapper/examples/minigzip.c