]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c. REL_13_STABLE github/REL_13_STABLE
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 5 Oct 2025 20:27:47 +0000 (16:27 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 5 Oct 2025 20:27:47 +0000 (16:27 -0400)
commitfc287cf3c4c98cef16297e89e5946a7c66ffa33e
tree34b1f84f798284f0afcb1fdcf5029dd87b76812e
parentf1a2f3a0c4ea51d9904fd30c9c11cb474312353b
Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c.

On Windows, this code did not handle error conditions correctly at
all, since it looked at "errno" which is not used for socket-related
errors on that platform.  This resulted, for example, in failure
to connect to a PostgreSQL server with GSSAPI enabled.

We have a convention for dealing with this within libpq, which is to
use SOCK_ERRNO and SOCK_ERRNO_SET rather than touching errno directly;
but the GSSAPI code is a relative latecomer and did not get that memo.
(The equivalent backend code continues to use errno, because the
backend does this differently.  Maybe libpq's approach should be
rethought someday.)

Apparently nobody tries to build libpq with GSSAPI support on Windows,
or we'd have heard about this before, because it's been broken all
along.  Back-patch to all supported branches.

Author: Ning Wu <ning94803@gmail.com>
Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAFGqpvg-pRw=cdsUpKYfwY6D3d-m9tw8WMcAEE7HHWfm-oYWvw@mail.gmail.com
Backpatch-through: 13
src/interfaces/libpq/fe-secure-gssapi.c