]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: syslog should be enabled by default 14050/head
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 8 Apr 2024 11:14:21 +0000 (13:14 +0200)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 8 Apr 2024 11:14:21 +0000 (13:14 +0200)
commit22931f35e56ff2c0b5e2147c157a5a765d60b8a2
tree4257e31b46a1c2cd29076ce8ec0bb333a86a59b9
parentbc68688084162727f65e824f14e1705819771cf6
dnsdist: syslog should be enabled by default

Regression introduced with the logging refactoring of dnsdist.

In rel/dnsdist-1.8.x: https://github.com/PowerDNS/pdns/blob/4d5bb67a2a75f9d88894e7dfc42bbbebfda297b0/pdns/dnsdist.cc#L103 :

bool g_syslog{true};

In master and 1.9.x the newly intrdoduced LoggingConfiguration::s_syslog
is inited to false.

This does not matter using the default systemd unit file as it disables syslog:

ExecStart=@bindir@/dnsdist --supervised --disable-syslog

but it does matter for non-systemd cases.
pdns/dnsdistdist/dolog.cc