]> git.ipfire.org Git - thirdparty/git.git/commit
gpg-interface: simplify ssh fingerprint parsing
authorChristian Couder <christian.couder@gmail.com>
Thu, 30 Oct 2025 12:33:28 +0000 (13:33 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 30 Oct 2025 14:06:58 +0000 (07:06 -0700)
commitee74c5b167372c4053ab4b3e0b798a1cd51d7e85
tree68dea6e4ff41dfd20bc50533d32eec30c45b643c
parent419c72cb8ada252b260efc38ff91fe201de7c8c3
gpg-interface: simplify ssh fingerprint parsing

In "gpg-interface.c", the 'parse_ssh_output()' function takes a
'struct signature_check *sigc' argument and populates many members of
this 'sigc' using information parsed from 'sigc->output' which
contains the ouput of an `ssh-keygen -Y ...` command that was used to
verify an SSH signature.

When it populates 'sigc->fingerprint' though, it uses
`xstrdup(strstr(line, "key ") + 4)` while `strstr(line, "key ")` has
already been computed a few lines above and is already available in
the `key` variable.

Let's simplify this.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gpg-interface.c