We need to make an IR symbol visible if it is defined in an IR object
and referenced in a dynamic object. When --as-needed is used, since
linker removes the IR symbol reference of the dynamic object if the
dynamic object isn't needed in the first pass, the IR definition isn't
visible to the dynamic object even if the dynamic object becomes needed
in the second pass. Add dynamic_ref_after_ir_def to bfd_link_hash_entry
to track IR symbol which is defined in an IR object and later referenced
in a dynamic object. dynamic_ref_after_ir_def is preserved when restoring
the symbol table for unneeded dynamic object.
bfd/
PR ld/21382
* elflink.c (elf_link_add_object_symbols): Preserve
dynamic_ref_after_ir_def when restoring the symbol table for
unneeded dynamic object.
include/
PR ld/21382
* bfdlink.h (bfd_link_hash_entry): Add dynamic_ref_after_ir_def.
ld/
PR ld/21382
* plugin.c (is_visible_from_outside): Symbol may be visible
from outside if dynamic_ref_after_ir_def is set.
(plugin_notice): Set dynamic_ref_after_ir_def if the symbol is
defined in an IR object and referenced in a dynamic object.
* testsuite/ld-plugin/lto.exp: Run PR ld/21382 tests.
* testsuite/ld-plugin/pr21382a.c: New file.
* testsuite/ld-plugin/pr21382b.c: Likewise.
+2017-04-20 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/21382
+ * elflink.c (elf_link_add_object_symbols): Preserve
+ dynamic_ref_after_ir_def when restoring the symbol table for
+ unneeded dynamic object.
+
2017-04-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/21401
2017-04-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/21401
struct elf_link_hash_entry *h;
bfd_size_type size;
unsigned int alignment_power;
struct elf_link_hash_entry *h;
bfd_size_type size;
unsigned int alignment_power;
+ unsigned int dynamic_ref_after_ir_def;
for (p = htab->root.table.table[i]; p != NULL; p = p->next)
{
for (p = htab->root.table.table[i]; p != NULL; p = p->next)
{
size = 0;
alignment_power = 0;
}
size = 0;
alignment_power = 0;
}
+ /* Preserve dynamic_ref_after_ir_def so that this symbol
+ will be exported when the dynamic lib becomes needed
+ in the second pass. */
+ dynamic_ref_after_ir_def = h->root.dynamic_ref_after_ir_def;
memcpy (p, old_ent, htab->root.table.entsize);
old_ent = (char *) old_ent + htab->root.table.entsize;
h = (struct elf_link_hash_entry *) p;
memcpy (p, old_ent, htab->root.table.entsize);
old_ent = (char *) old_ent + htab->root.table.entsize;
h = (struct elf_link_hash_entry *) p;
if (alignment_power > h->root.u.c.p->alignment_power)
h->root.u.c.p->alignment_power = alignment_power;
}
if (alignment_power > h->root.u.c.p->alignment_power)
h->root.u.c.p->alignment_power = alignment_power;
}
+ h->root.dynamic_ref_after_ir_def = dynamic_ref_after_ir_def;
+2017-04-20 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/21382
+ * bfdlink.h (bfd_link_hash_entry): Add dynamic_ref_after_ir_def.
+
2017-04-19 Alan Modra <amodra@gmail.com>
* bfdlink.h (struct bfd_link_info <dynamic_undefined_weak>):
2017-04-19 Alan Modra <amodra@gmail.com>
* bfdlink.h (struct bfd_link_info <dynamic_undefined_weak>):
IR object file. */
unsigned int non_ir_ref : 1;
IR object file. */
unsigned int non_ir_ref : 1;
+ /* Symbol is referenced in a dynamic object after it has been defined
+ in an IR object. */
+ unsigned int dynamic_ref_after_ir_def : 1;
+
/* Symbol is a built-in define. These will be overridden by PROVIDE
in a linker script. */
unsigned int linker_def : 1;
/* Symbol is a built-in define. These will be overridden by PROVIDE
in a linker script. */
unsigned int linker_def : 1;
+2017-04-20 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/21382
+ * plugin.c (is_visible_from_outside): Symbol may be visible
+ from outside if dynamic_ref_after_ir_def is set.
+ (plugin_notice): Set dynamic_ref_after_ir_def if the symbol is
+ defined in an IR object and referenced in a dynamic object.
+ * testsuite/ld-plugin/lto.exp: Run PR ld/21382 tests.
+ * testsuite/ld-plugin/pr21382a.c: New file.
+ * testsuite/ld-plugin/pr21382b.c: Likewise.
+
2017-04-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/21401
2017-04-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/21401
if (bfd_link_relocatable (&link_info))
return TRUE;
if (bfd_link_relocatable (&link_info))
return TRUE;
- if (link_info.export_dynamic || bfd_link_dll (&link_info))
+ if (blhe->dynamic_ref_after_ir_def
+ || link_info.export_dynamic
+ || bfd_link_dll (&link_info))
{
/* Check if symbol is hidden by version script. */
if (bfd_hide_sym_by_version (link_info.version_info,
{
/* Check if symbol is hidden by version script. */
if (bfd_hide_sym_by_version (link_info.version_info,
/* If this is a ref, set non_ir_ref. */
else if (bfd_is_und_section (section))
{
/* If this is a ref, set non_ir_ref. */
else if (bfd_is_und_section (section))
{
+ if (h->type == bfd_link_hash_defweak
+ || h->type == bfd_link_hash_defined)
+ {
+ /* Check if the symbol is referenced in a dynamic object
+ after it has been defined in an IR object. */
+ if ((abfd->flags & DYNAMIC) != 0
+ && is_ir_dummy_bfd (h->u.def.section->owner))
+ h->dynamic_ref_after_ir_def = TRUE;
+ }
/* Replace the undefined dummy bfd with the real one. */
/* Replace the undefined dummy bfd with the real one. */
- if ((h->type == bfd_link_hash_undefined
- || h->type == bfd_link_hash_undefweak)
- && (h->u.undef.abfd == NULL
- || (h->u.undef.abfd->flags & BFD_PLUGIN) != 0))
- h->u.undef.abfd = abfd;
+ else if ((h->type == bfd_link_hash_undefined
+ || h->type == bfd_link_hash_undefweak)
+ && (h->u.undef.abfd == NULL
+ || (h->u.undef.abfd->flags & BFD_PLUGIN) != 0))
+ h->u.undef.abfd = abfd;
[list "PR ld/14918" \
"-flto" "-flto" \
{pr14918.c} {{"readelf" {-d --wide} "pr14918.d"}} "pr14918.exe" "c"] \
[list "PR ld/14918" \
"-flto" "-flto" \
{pr14918.c} {{"readelf" {-d --wide} "pr14918.d"}} "pr14918.exe" "c"] \
+ [list "Build pr21382a.o" \
+ "" "-O2 -flto" \
+ {pr21382a.c} {} "" "c"] \
+ [list "Build pr21382.so" \
+ "-shared" "-O2 -fpic" \
+ {pr21382b.c} {} "pr21382.so" "c"] \
]
# Check final symbols in executables.
]
# Check final symbols in executables.
[list "LTO 7" \
"-O2 -flto -fuse-linker-plugin tmpdir/lto-7b.o tmpdir/lto-7c.o tmpdir/lto-7a.o -Wl,--no-as-needed tmpdir/liblto-7.so" "" \
{dummy.c} "lto-7.exe" "lto-7.out" "" "c"] \
[list "LTO 7" \
"-O2 -flto -fuse-linker-plugin tmpdir/lto-7b.o tmpdir/lto-7c.o tmpdir/lto-7a.o -Wl,--no-as-needed tmpdir/liblto-7.so" "" \
{dummy.c} "lto-7.exe" "lto-7.out" "" "c"] \
+ [list "Run pr21382" \
+ "-O2 -flto -fuse-linker-plugin -Wl,--as-needed tmpdir/pr21382a.o tmpdir/pr21382.so" "" \
+ {dummy.c} "pr21382.exe" "pass.out" "" "c"] \
]
# LTO run-time tests for ELF
]
# LTO run-time tests for ELF
--- /dev/null
+#include <stdio.h>
+
+extern void y (void);
+
+void
+x (void)
+{
+ printf ("PASS\n");
+}
+
+
+int
+main (void)
+{
+ y ();
+ return 0;
+}
--- /dev/null
+extern void x (void);
+
+void
+y (void)
+{
+ x ();
+}