pinctrl: stm32: fix hwspinlock resource leak in probe function

In stm32_pctl_probe(), hwspin_lock_request_specific() is called to
request a hwspinlock, but the acquired lock is not freed on multiple
error paths after this call. This causes resource leakage when the
function fails to initialize properly.

Use devm_hwspin_lock_request_specific() instead of
hwspin_lock_request_specific() to automatically manage the hwspinlock
resource lifecycle.

Fixes: 97cfb6cd34f2 ("pinctrl: stm32: protect configuration registers with a hwspinlock")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 5f8829fdd9851779c5aa97c981b0f1f21d1d14c2..ceb9e19f2290d6cebf6de683b0fffe763555b063 100644 (file)
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1872,7 +1872,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
                if (hwlock_id == -EPROBE_DEFER)
                        return hwlock_id;
        } else {
-               pctl->hwlock = hwspin_lock_request_specific(hwlock_id);
+               pctl->hwlock = devm_hwspin_lock_request_specific(dev, hwlock_id);
        }
 
        spin_lock_init(&pctl->irqmux_lock);