]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
radiotap: Initialize all members in ieee80211_radiotap_iterator_init()
authorJouni Malinen <j@w1.fi>
Sun, 23 Nov 2014 18:23:35 +0000 (20:23 +0200)
committerJouni Malinen <j@w1.fi>
Sun, 23 Nov 2014 19:03:40 +0000 (21:03 +0200)
_next_ns_data could look like it would be used uninitialized in
ieee80211_radiotap_iterator_next() to static analyzers. Avoid
unnecessary reports by explicitly initializing all variables in struct
ieee80211_radiotap_iterator. (CID 62878)

Signed-off-by: Jouni Malinen <j@w1.fi>
src/utils/radiotap.c

index 197a4af9855574f3a355eed6c0e0af3c4cd325ae..f8f815a86be923531244232c85d025a08b2c2ae4 100644 (file)
@@ -109,6 +109,7 @@ int ieee80211_radiotap_iterator_init(
        iterator->_arg_index = 0;
        iterator->_bitmap_shifter = get_unaligned_le32(&radiotap_header->it_present);
        iterator->_arg = (uint8_t *)radiotap_header + sizeof(*radiotap_header);
+       iterator->_next_ns_data = NULL;
        iterator->_reset_on_ext = 0;
        iterator->_next_bitmap = &radiotap_header->it_present;
        iterator->_next_bitmap++;
@@ -154,6 +155,8 @@ int ieee80211_radiotap_iterator_init(
        }
 
        iterator->this_arg = iterator->_arg;
+       iterator->this_arg_index = 0;
+       iterator->this_arg_size = 0;
 
        /* we are all initialized happily */