rtc: s5m: cache device type during probe

platform_get_device_id() is called mulitple times during probe to
retrieve the device type. This makes the code harder to read than
necessary.

Just get the type once, which also trims the lengths of the lines
involved.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250409-s2mpg10-v4-25-d66d5f39b6bf@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index db5c9b641277213aa1371776c63e2eda3f223465..c7636738b797b8087a0ed6844df62d47427e33b8 100644 (file)
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info)
 static int s5m_rtc_probe(struct platform_device *pdev)
 {
        struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent);
+       enum sec_device_type device_type =
+               platform_get_device_id(pdev)->driver_data;
        struct s5m_rtc_info *info;
        struct i2c_client *i2c;
        const struct regmap_config *regmap_cfg;
@@ -646,7 +648,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
        if (!info)
                return -ENOMEM;
 
-       switch (platform_get_device_id(pdev)->driver_data) {
+       switch (device_type) {
        case S2MPS15X:
                regmap_cfg = &s2mps14_rtc_regmap_config;
                info->regs = &s2mps15_rtc_regs;
@@ -669,8 +671,8 @@ static int s5m_rtc_probe(struct platform_device *pdev)
                break;
        default:
                return dev_err_probe(&pdev->dev, -ENODEV,
-                                    "Device type %lu is not supported by RTC driver\n",
-                                    platform_get_device_id(pdev)->driver_data);
+                                    "Device type %d is not supported by RTC driver\n",
+                                    device_type);
        }
 
        i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter,
@@ -686,7 +688,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
 
        info->dev = &pdev->dev;
        info->s5m87xx = s5m87xx;
-       info->device_type = platform_get_device_id(pdev)->driver_data;
+       info->device_type = device_type;
 
        if (s5m87xx->irq_data) {
                info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq);