]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
stmmac: loongson: Pass correct arg to PCI function
authorPhilipp Stanner <phasta@kernel.org>
Wed, 26 Feb 2025 08:52:05 +0000 (09:52 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Feb 2025 02:36:37 +0000 (18:36 -0800)
pcim_iomap_regions() should receive the driver's name as its third
parameter, not the PCI device's name.

Define the driver name with a macro and use it at the appropriate
places, including pcim_iomap_regions().

Cc: stable@vger.kernel.org # v5.14+
Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Yanteng Si <si.yanteng@linux.dev>
Tested-by: Henry Chen <chenx97@aosc.io>
Link: https://patch.msgid.link/20250226085208.97891-2-phasta@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c

index f5acfb7d4ff655088ab4a9795726e82a4c7b0cd4..ab7c2750c104258835e62f71df034558581e0f02 100644 (file)
@@ -11,6 +11,8 @@
 #include "dwmac_dma.h"
 #include "dwmac1000.h"
 
+#define DRIVER_NAME "dwmac-loongson-pci"
+
 /* Normal Loongson Tx Summary */
 #define DMA_INTR_ENA_NIE_TX_LOONGSON   0x00040000
 /* Normal Loongson Rx Summary */
@@ -568,7 +570,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
        for (i = 0; i < PCI_STD_NUM_BARS; i++) {
                if (pci_resource_len(pdev, i) == 0)
                        continue;
-               ret = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));
+               ret = pcim_iomap_regions(pdev, BIT(0), DRIVER_NAME);
                if (ret)
                        goto err_disable_device;
                break;
@@ -687,7 +689,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = {
 MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);
 
 static struct pci_driver loongson_dwmac_driver = {
-       .name = "dwmac-loongson-pci",
+       .name = DRIVER_NAME,
        .id_table = loongson_dwmac_id_table,
        .probe = loongson_dwmac_probe,
        .remove = loongson_dwmac_remove,