]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Use dom_sid_dup() instead of talloc_memdup()
authorVolker Lendecke <vl@samba.org>
Thu, 28 Nov 2024 11:09:50 +0000 (12:09 +0100)
committerMartin Schwenke <martins@samba.org>
Mon, 2 Dec 2024 04:53:33 +0000 (04:53 +0000)
We have specialized code for this, why not use it...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
libcli/security/create_descriptor.c

index b85b54111481d3fa923ca2a36474429a1db978da..d8575f59b8bc0b729777212a511f174438192f9c 100644 (file)
@@ -652,8 +652,8 @@ struct security_descriptor *create_security_descriptor(
                new_group = creator_sd->group_sid;
        }
 
-       new_sd->owner_sid = talloc_memdup(new_sd, new_owner, sizeof(struct dom_sid));
-       new_sd->group_sid = talloc_memdup(new_sd, new_group, sizeof(struct dom_sid));
+       new_sd->owner_sid = dom_sid_dup(new_sd, new_owner);
+       new_sd->group_sid = dom_sid_dup(new_sd, new_group);
        if (!new_sd->owner_sid || !new_sd->group_sid){
                talloc_free(new_sd);
                return NULL;