]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/mips-gic: Fix selection of GENERIC_IRQ_EFFECTIVE_AFF_MASK
authorNathan Chancellor <nathan@kernel.org>
Fri, 1 Nov 2024 16:33:05 +0000 (09:33 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 1 Nov 2024 21:15:56 +0000 (22:15 +0100)
Without SMP enabled (such as in allnoconfig), there is a Kconfig warning
because CONFIG_IRQ_EFFECTIVE_AFF_MASK is unconditionally selected by
CONFIG_MIPS_GIC:

  WARNING: unmet direct dependencies detected for GENERIC_IRQ_EFFECTIVE_AFF_MASK
    Depends on [n]: SMP [=n]
    Selected by [y]:
    - MIPS_GIC [=y]

Add a dependency on SMP to the selection, which matches all other
selections of CONFIG_IRQ_EFFECTIVE_AFF_MASK.

Fixes: 322a90638768 ("irqchip/mips-gic: Multi-cluster support")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241101-mips-fix-generic_irq_effective_aff_mask-select-v1-1-d94db6e0de0d@kernel.org
drivers/irqchip/Kconfig

index f20adf759d401089576ef963437017d4f1f495de..ef0fa6975dab9502efda80cdc0c5e21c251f4abd 100644 (file)
@@ -352,7 +352,7 @@ config KEYSTONE_IRQ
 
 config MIPS_GIC
        bool
-       select GENERIC_IRQ_EFFECTIVE_AFF_MASK
+       select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
        select GENERIC_IRQ_IPI if SMP
        select IRQ_DOMAIN_HIERARCHY
        select MIPS_CM