]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: vertexcom: mse102x: Silence TX timeout
authorStefan Wahren <wahrenst@gmx.net>
Tue, 27 Aug 2024 19:09:57 +0000 (21:09 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 18:39:35 +0000 (11:39 -0700)
As long as the MSE102x is not operational, every packet transmission
will run into a TX timeout and flood the kernel log. So log only the
first TX timeout and a user is at least informed about this issue.
The amount of timeouts are still available via netstat.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827191000.3244-3-wahrenst@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/vertexcom/mse102x.c

index 0711641fc3c972305bb67829c97d11e2ebd2b2d3..336435fe8241935dbc60c7783e958b237df93e70 100644 (file)
@@ -451,7 +451,7 @@ static void mse102x_tx_work(struct work_struct *work)
 
        if (ret == -ETIMEDOUT) {
                if (netif_msg_timer(mse))
-                       netdev_err(mse->ndev, "tx work timeout\n");
+                       netdev_err_once(mse->ndev, "tx work timeout\n");
 
                mse->stats.tx_timeout++;
        }