]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bus: ti-sysc: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:39 +0000 (13:12 -0600)
committerKevin Hilman <khilman@baylibre.com>
Mon, 5 Aug 2024 17:34:18 +0000 (10:34 -0700)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct
property' pointer. It didn't matter as "prop" was never dereferenced.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-1-robh@kernel.org
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
drivers/bus/ti-sysc.c

index 2b59ef61dda23b77243693be2c33bc02effdb2a5..7caaf89f3bf291a2788449eed72aee7bfea7b71e 100644 (file)
@@ -2569,14 +2569,12 @@ static const struct sysc_dts_quirk sysc_dts_quirks[] = {
 static void sysc_parse_dts_quirks(struct sysc *ddata, struct device_node *np,
                                  bool is_child)
 {
-       const struct property *prop;
-       int i, len;
+       int i;
 
        for (i = 0; i < ARRAY_SIZE(sysc_dts_quirks); i++) {
                const char *name = sysc_dts_quirks[i].name;
 
-               prop = of_get_property(np, name, &len);
-               if (!prop)
+               if (!of_property_present(np, name))
                        continue;
 
                ddata->cfg.quirks |= sysc_dts_quirks[i].mask;