]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 15 Mar 2021 09:23:37 +0000 (12:23 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 07:50:34 +0000 (09:50 +0200)
[ Upstream commit c9eaee0c2ec6b1002044fb698cdfb5d9ef4ed28c ]

The sscanf() function returns the number of matches (0 or 1 in this
case).  It doesn't return error codes.  We should return -EINVAL if the
string is invalid

Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/YE8nmatMDBDDWkjq@mwanda
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw88/debug.c

index efbba9caef3bfef87015c5d506c3ecdeb3a1cff4..8bb6cc8ca74e587ef0eec27fb9afbe038914ad3c 100644 (file)
@@ -270,7 +270,7 @@ static ssize_t rtw_debugfs_set_rsvd_page(struct file *filp,
 
        if (num != 2) {
                rtw_warn(rtwdev, "invalid arguments\n");
-               return num;
+               return -EINVAL;
        }
 
        debugfs_priv->rsvd_page.page_offset = offset;