]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
upstream: fix test: getnameinfo returns a non-zero value on error, not
authordjm@openbsd.org <djm@openbsd.org>
Mon, 27 Mar 2023 03:31:05 +0000 (03:31 +0000)
committerDamien Miller <djm@mindrot.org>
Mon, 27 Mar 2023 03:31:57 +0000 (14:31 +1100)
(neccessarily) -1. From GHPR#384

OpenBSD-Commit-ID: d35e2b71268f66f5543a7ea68751972b3ae22b25

addr.c

diff --git a/addr.c b/addr.c
index db9ab7ac1d8d5d876019fca1cbb6005d9bbb164d..fa8c66922bf871aa4e81832e109f2e96462f136b 100644 (file)
--- a/addr.c
+++ b/addr.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: addr.c,v 1.6 2022/10/28 02:29:34 djm Exp $ */
+/* $OpenBSD: addr.c,v 1.7 2023/03/27 03:31:05 djm Exp $ */
 
 /*
  * Copyright (c) 2004-2008 Damien Miller <djm@mindrot.org>
@@ -443,7 +443,7 @@ addr_ntop(const struct xaddr *n, char *p, size_t len)
        if (p == NULL || len == 0)
                return -1;
        if (getnameinfo(_SA(&ss), slen, p, len, NULL, 0,
-           NI_NUMERICHOST) == -1)
+           NI_NUMERICHOST) != 0)
                return -1;
 
        return 0;