]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
tools: ynl-gen-c: annotate valid choices for --mode
authorJohannes Berg <johannes.berg@intel.com>
Fri, 6 Dec 2024 10:30:56 +0000 (11:30 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sun, 8 Dec 2024 01:27:59 +0000 (17:27 -0800)
This makes argparse validate the input and helps users
understand which modes are possible.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20241206113100.e2ab5cf6937c.Ie149a0ca5df713860964b44fe9d9ae547f2e1553@changeid
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/ynl-gen-c.py

index 8098bcbb6f40475c1dd81427feebc96cd34444b9..7f6e5157770d3960b7a9472d05059c7d130fadf7 100755 (executable)
@@ -2706,7 +2706,8 @@ def find_kernel_root(full_path):
 
 def main():
     parser = argparse.ArgumentParser(description='Netlink simple parsing generator')
-    parser.add_argument('--mode', dest='mode', type=str, required=True)
+    parser.add_argument('--mode', dest='mode', type=str, required=True,
+                        choices=('user', 'kernel', 'uapi'))
     parser.add_argument('--spec', dest='spec', type=str, required=True)
     parser.add_argument('--header', dest='header', action='store_true', default=None)
     parser.add_argument('--source', dest='header', action='store_false')