]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: ov13858: simplify getting state container
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 21 Sep 2020 16:23:32 +0000 (18:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:11 +0000 (10:31 +0100)
The pointer to 'struct v4l2_subdev' is stored in drvdata via
v4l2_i2c_subdev_init() so there is no point of a dance like:

    struct i2c_client *client = to_i2c_client(struct device *dev)
    struct v4l2_subdev *sd = i2c_get_clientdata(client);

This allows to remove local variable 'client' and few pointer
dereferences.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ov13858.c

index 236ad2c816b70ad916f58c3aa528dfdc2d0acc59..2f3be7a80cef4c8db9e358b3e42a64674b43abfa 100644 (file)
@@ -1505,8 +1505,7 @@ err_unlock:
 
 static int __maybe_unused ov13858_suspend(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct v4l2_subdev *sd = dev_get_drvdata(dev);
        struct ov13858 *ov13858 = to_ov13858(sd);
 
        if (ov13858->streaming)
@@ -1517,8 +1516,7 @@ static int __maybe_unused ov13858_suspend(struct device *dev)
 
 static int __maybe_unused ov13858_resume(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct v4l2_subdev *sd = dev_get_drvdata(dev);
        struct ov13858 *ov13858 = to_ov13858(sd);
        int ret;