]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: mm: use ptep_clear() instead of pte_clear() in clear_flush()
authorQi Zheng <zhengqi.arch@bytedance.com>
Thu, 10 Aug 2023 09:32:41 +0000 (09:32 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 24 Aug 2023 23:20:27 +0000 (16:20 -0700)
In clear_flush(), the original pte may be a present entry, so we should
use ptep_clear() to let page_table_check track the pte clearing operation,
otherwise it may cause false positive in subsequent set_pte_at().

Link: https://lkml.kernel.org/r/20230810093241.1181142-1-qi.zheng@linux.dev
Fixes: 42b2547137f5 ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/arm64/mm/hugetlbpage.c

index 21716c9406821ec43c918bdf1dc3453948f6ad41..9c52718ea7509a88ddbafa2eceef58b2e51615a6 100644 (file)
@@ -236,7 +236,7 @@ static void clear_flush(struct mm_struct *mm,
        unsigned long i, saddr = addr;
 
        for (i = 0; i < ncontig; i++, addr += pgsize, ptep++)
-               pte_clear(mm, addr, ptep);
+               ptep_clear(mm, addr, ptep);
 
        flush_tlb_range(&vma, saddr, addr);
 }