thermal: testing: Initialize some variables annoteded with _free()

Variables annotated with __free() need to be initialized if the function
can return before they get updated for the first time or the attempt to
free the memory pointed to by them upon function return may crash the
kernel.

Fix this issue in some places in the thermal testing code.

Fixes: f6a034f2df42 ("thermal: Introduce a debugfs-based testing facility")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12576267.O9o76ZdvQC@rjwysocki.net

diff --git a/drivers/thermal/testing/zone.c b/drivers/thermal/testing/zone.c
index 2619d3df5bd9d780557b5b2889c8cf08c6343263..1f4e450100e2f179ca84846c22d1d11a7557acc7 100644 (file)
--- a/drivers/thermal/testing/zone.c
+++ b/drivers/thermal/testing/zone.c
@@ -185,7 +185,7 @@ static void tt_add_tz_work_fn(struct work_struct *work)
 int tt_add_tz(void)
 {
        struct tt_thermal_zone *tt_zone __free(kfree);
-       struct tt_work *tt_work __free(kfree);
+       struct tt_work *tt_work __free(kfree) = NULL;
        int ret;
 
        tt_zone = kzalloc(sizeof(*tt_zone), GFP_KERNEL);
@@ -237,7 +237,7 @@ static void tt_zone_unregister_tz(struct tt_thermal_zone *tt_zone)
 
 int tt_del_tz(const char *arg)
 {
-       struct tt_work *tt_work __free(kfree);
+       struct tt_work *tt_work __free(kfree) = NULL;
        struct tt_thermal_zone *tt_zone, *aux;
        int ret;
        int id;
@@ -331,8 +331,8 @@ static void tt_zone_add_trip_work_fn(struct work_struct *work)
 int tt_zone_add_trip(const char *arg)
 {
        struct tt_thermal_zone *tt_zone __free(put_tt_zone) = NULL;
+       struct tt_trip *tt_trip __free(kfree) = NULL;
        struct tt_work *tt_work __free(kfree);
-       struct tt_trip *tt_trip __free(kfree);
        int id;
 
        tt_work = kzalloc(sizeof(*tt_work), GFP_KERNEL);
@@ -387,7 +387,7 @@ static struct thermal_zone_device_ops tt_zone_ops = {
 
 static int tt_zone_register_tz(struct tt_thermal_zone *tt_zone)
 {
-       struct thermal_trip *trips __free(kfree);
+       struct thermal_trip *trips __free(kfree) = NULL;
        struct thermal_zone_device *tz;
        struct tt_trip *tt_trip;
        int i;