]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t/lib-rebase: set_fake_editor(): handle FAKE_LINES more consistently
authorOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Mon, 7 Aug 2023 17:09:34 +0000 (19:09 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 7 Aug 2023 19:09:34 +0000 (12:09 -0700)
Default next action after 'fakesha' to preserving the command instead
of forcing 'pick', consistently with other "instant-effect" keywords.
There is no reason why one would want that inconsistency, so this was
clearly just an oversight in commit 5dcdd740 ("t/lib-rebase: prepare
for testing `git rebase --rebase-merges`"). Rectifying it makes the
behavior easier to reason about and document.

This would affect hypothetical "fakesha <n>" sequences where line <n>
already isn't a pick, which currently don't appear.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-rebase.sh

index e6179ab5298de6617953d44b54c6a82e27687138..9ed87ca7ab2a20d7c8989fb34e0710fb31b4b6eb 100644 (file)
@@ -64,7 +64,7 @@ set_fake_editor () {
                fakesha)
                        test \& != "$action" || action=pick
                        echo "$action XXXXXXX False commit" >> "$1"
-                       action=pick;;
+                       action=\&;;
                *)
                        sed -n "${line}s/^[a-z][a-z]*/$action/p" < "$1".tmp >> "$1"
                        action=\&;;