]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: lan969x: add RGMII implementation
authorDaniel Machon <daniel.machon@microchip.com>
Fri, 20 Dec 2024 13:48:47 +0000 (14:48 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 18:57:56 +0000 (10:57 -0800)
The lan969x switch device includes two RGMII port interfaces (port 28
and 29) supporting data speeds of 1 Gbps, 100 Mbps and 10 Mbps. MAC
level delays are configurable through the HSIO_WRAP target, by choosing
a phase shift selector, corresponding to a certain time delay in nano
seconds.

Add new file: lan969x_rgmii.c that contains the implementation for
configuring the RGMII port devices. MAC level delays are configured
using the "{rx,tx}-internal-delay-ps" properties. These properties must
be specified independently of the phy-mode. If missing, or set to zero,
the MAC will not apply any delay.

Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Tested-by: Robert Marko <robert.marko@sartura.hr>
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Link: https://patch.msgid.link/20241220-sparx5-lan969x-switch-driver-4-v5-8-fa8ba5dff732@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/sparx5/Makefile
drivers/net/ethernet/microchip/sparx5/lan969x/lan969x.c
drivers/net/ethernet/microchip/sparx5/lan969x/lan969x.h
drivers/net/ethernet/microchip/sparx5/lan969x/lan969x_rgmii.c [new file with mode: 0644]
drivers/net/ethernet/microchip/sparx5/sparx5_main.h
drivers/net/ethernet/microchip/sparx5/sparx5_port.c

index 4bf2a885a9da473d54ee5fe1581e71f04ed5384c..3f34e83246a0e1e934e6ddae0de868ff6c8c5f91 100644 (file)
@@ -20,7 +20,8 @@ sparx5-switch-$(CONFIG_LAN969X_SWITCH) += lan969x/lan969x_regs.o \
                                          lan969x/lan969x.o \
                                          lan969x/lan969x_calendar.o \
                                          lan969x/lan969x_vcap_ag_api.o \
-                                         lan969x/lan969x_vcap_impl.o
+                                         lan969x/lan969x_vcap_impl.o \
+                                         lan969x/lan969x_rgmii.o
 
 # Provide include files
 ccflags-y += -I$(srctree)/drivers/net/ethernet/microchip/vcap
index be49a99556fe9a5050253a5208b45e45171c1ef6..396f76b6eea5d93abfed030218f72c5a29361690 100644 (file)
@@ -340,6 +340,7 @@ static const struct sparx5_ops lan969x_ops = {
        .set_port_mux            = &lan969x_port_mux_set,
        .ptp_irq_handler         = &lan969x_ptp_irq_handler,
        .dsm_calendar_calc       = &lan969x_dsm_calendar_calc,
+       .port_config_rgmii       = &lan969x_port_config_rgmii,
 };
 
 const struct sparx5_match_data lan969x_desc = {
index 4b91c47d6d216a1b015edd181c7c76b63c70722c..9a7ddebecf1e448e1e436d39db06d2482245b4f8 100644 (file)
@@ -67,4 +67,9 @@ static inline bool lan969x_port_is_rgmii(int portno)
 /* lan969x_calendar.c */
 int lan969x_dsm_calendar_calc(struct sparx5 *sparx5, u32 taxi,
                              struct sparx5_calendar_data *data);
+
+/* lan969x_rgmii.c */
+int lan969x_port_config_rgmii(struct sparx5_port *port,
+                             struct sparx5_port_config *conf);
+
 #endif
diff --git a/drivers/net/ethernet/microchip/sparx5/lan969x/lan969x_rgmii.c b/drivers/net/ethernet/microchip/sparx5/lan969x/lan969x_rgmii.c
new file mode 100644 (file)
index 0000000..4e422ca
--- /dev/null
@@ -0,0 +1,224 @@
+// SPDX-License-Identifier: GPL-2.0+
+/* Microchip lan969x Switch driver
+ *
+ * Copyright (c) 2024 Microchip Technology Inc. and its subsidiaries.
+ */
+
+#include "lan969x.h"
+
+/* Tx clock selectors */
+#define LAN969X_RGMII_TX_CLK_SEL_125MHZ 1  /* 1000Mbps */
+#define LAN969X_RGMII_TX_CLK_SEL_25MHZ  2  /* 100Mbps */
+#define LAN969X_RGMII_TX_CLK_SEL_2M5MHZ 3  /* 10Mbps */
+
+/* Port speed selectors */
+#define LAN969X_RGMII_SPEED_SEL_10 0   /* Select 10Mbps speed */
+#define LAN969X_RGMII_SPEED_SEL_100 1  /* Select 100Mbps speed */
+#define LAN969X_RGMII_SPEED_SEL_1000 2 /* Select 1000Mbps speed */
+
+/* Clock delay selectors */
+#define LAN969X_RGMII_CLK_DELAY_SEL_1_0_NS 2  /* Phase shift 45deg */
+#define LAN969X_RGMII_CLK_DELAY_SEL_1_7_NS 3  /* Phase shift 77deg */
+#define LAN969X_RGMII_CLK_DELAY_SEL_2_0_NS 4  /* Phase shift 90deg */
+#define LAN969X_RGMII_CLK_DELAY_SEL_2_5_NS 5  /* Phase shift 112deg */
+#define LAN969X_RGMII_CLK_DELAY_SEL_3_0_NS 6  /* Phase shift 135deg */
+#define LAN969X_RGMII_CLK_DELAY_SEL_3_3_NS 7  /* Phase shift 147deg */
+
+#define LAN969X_RGMII_PORT_START_IDX 28 /* Index of the first RGMII port */
+#define LAN969X_RGMII_IFG_TX 4          /* TX Inter Frame Gap value */
+#define LAN969X_RGMII_IFG_RX1 5         /* RX1 Inter Frame Gap value */
+#define LAN969X_RGMII_IFG_RX2 1         /* RX2 Inter Frame Gap value */
+
+#define RGMII_PORT_IDX(port) ((port)->portno - LAN969X_RGMII_PORT_START_IDX)
+
+/* Get the tx clock selector based on the port speed. */
+static int lan969x_rgmii_get_clk_sel(int speed)
+{
+       return (speed == SPEED_10  ? LAN969X_RGMII_TX_CLK_SEL_2M5MHZ :
+               speed == SPEED_100 ? LAN969X_RGMII_TX_CLK_SEL_25MHZ :
+                                    LAN969X_RGMII_TX_CLK_SEL_125MHZ);
+}
+
+/* Get the port speed selector based on the port speed. */
+static int lan969x_rgmii_get_speed_sel(int speed)
+{
+       return (speed == SPEED_10  ? LAN969X_RGMII_SPEED_SEL_10 :
+               speed == SPEED_100 ? LAN969X_RGMII_SPEED_SEL_100 :
+                                    LAN969X_RGMII_SPEED_SEL_1000);
+}
+
+/* Get the clock delay selector based on the clock delay in picoseconds. */
+static int lan969x_rgmii_get_clk_delay_sel(struct sparx5_port *port,
+                                          u32 delay_ps, u32 *clk_delay_sel)
+{
+       switch (delay_ps) {
+       case 0:
+               /* Hardware default selector. */
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_2_5_NS;
+               break;
+       case 1000:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_1_0_NS;
+               break;
+       case 1700:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_1_7_NS;
+               break;
+       case 2000:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_2_0_NS;
+               break;
+       case 2500:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_2_5_NS;
+               break;
+       case 3000:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_3_0_NS;
+               break;
+       case 3300:
+               *clk_delay_sel = LAN969X_RGMII_CLK_DELAY_SEL_3_3_NS;
+               break;
+       default:
+               dev_err(port->sparx5->dev, "Invalid RGMII delay: %u", delay_ps);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+/* Configure the RGMII tx clock frequency. */
+static void lan969x_rgmii_tx_clk_config(struct sparx5_port *port,
+                                       struct sparx5_port_config *conf)
+{
+       u32 clk_sel = lan969x_rgmii_get_clk_sel(conf->speed);
+       u32 idx = RGMII_PORT_IDX(port);
+
+       /* Take the RGMII clock domain out of reset and set tx clock
+        * frequency.
+        */
+       spx5_rmw(HSIO_WRAP_RGMII_CFG_TX_CLK_CFG_SET(clk_sel) |
+                HSIO_WRAP_RGMII_CFG_RGMII_TX_RST_SET(0) |
+                HSIO_WRAP_RGMII_CFG_RGMII_RX_RST_SET(0),
+                HSIO_WRAP_RGMII_CFG_TX_CLK_CFG |
+                HSIO_WRAP_RGMII_CFG_RGMII_TX_RST |
+                HSIO_WRAP_RGMII_CFG_RGMII_RX_RST,
+                port->sparx5, HSIO_WRAP_RGMII_CFG(idx));
+}
+
+/* Configure the RGMII port device. */
+static void lan969x_rgmii_port_device_config(struct sparx5_port *port,
+                                            struct sparx5_port_config *conf)
+{
+       u32 dtag, dotag, etype, speed_sel, idx = RGMII_PORT_IDX(port);
+
+       speed_sel = lan969x_rgmii_get_speed_sel(conf->speed);
+
+       etype = (port->vlan_type == SPX5_VLAN_PORT_TYPE_S_CUSTOM ?
+                port->custom_etype :
+                port->vlan_type == SPX5_VLAN_PORT_TYPE_C ?
+                ETH_P_8021Q : ETH_P_8021AD);
+
+       dtag = port->max_vlan_tags == SPX5_PORT_MAX_TAGS_TWO;
+       dotag = port->max_vlan_tags != SPX5_PORT_MAX_TAGS_NONE;
+
+       /* Enable the MAC. */
+       spx5_wr(DEVRGMII_MAC_ENA_CFG_RX_ENA_SET(1) |
+               DEVRGMII_MAC_ENA_CFG_TX_ENA_SET(1),
+               port->sparx5, DEVRGMII_MAC_ENA_CFG(idx));
+
+       /* Configure the Inter Frame Gap. */
+       spx5_wr(DEVRGMII_MAC_IFG_CFG_TX_IFG_SET(LAN969X_RGMII_IFG_TX) |
+               DEVRGMII_MAC_IFG_CFG_RX_IFG1_SET(LAN969X_RGMII_IFG_RX1) |
+               DEVRGMII_MAC_IFG_CFG_RX_IFG2_SET(LAN969X_RGMII_IFG_RX2),
+               port->sparx5, DEVRGMII_MAC_IFG_CFG(idx));
+
+       /* Configure port data rate. */
+       spx5_wr(DEVRGMII_DEV_RST_CTRL_SPEED_SEL_SET(speed_sel),
+               port->sparx5, DEVRGMII_DEV_RST_CTRL(idx));
+
+       /* Configure VLAN awareness. */
+       spx5_wr(DEVRGMII_MAC_TAGS_CFG_TAG_ID_SET(etype) |
+               DEVRGMII_MAC_TAGS_CFG_PB_ENA_SET(dtag) |
+               DEVRGMII_MAC_TAGS_CFG_VLAN_AWR_ENA_SET(dotag) |
+               DEVRGMII_MAC_TAGS_CFG_VLAN_LEN_AWR_ENA_SET(dotag),
+               port->sparx5,
+               DEVRGMII_MAC_TAGS_CFG(idx));
+}
+
+/* Configure the RGMII delay lines in the MAC.
+ *
+ * We use the rx-internal-delay-ps" and "tx-internal-delay-ps" properties to
+ * configure the rx and tx delays for the MAC. If these properties are missing
+ * or set to zero, the MAC will not apply any delay.
+ *
+ * The PHY side delays are determined by the PHY mode
+ * (e.g. PHY_INTERFACE_MODE_RGMII_{ID, RXID, TXID}), and ignored by the MAC side
+ * entirely.
+ */
+static int lan969x_rgmii_delay_config(struct sparx5_port *port,
+                                     struct sparx5_port_config *conf)
+{
+       u32 tx_clk_sel, rx_clk_sel, tx_delay_ps = 0, rx_delay_ps = 0;
+       u32 idx = RGMII_PORT_IDX(port);
+       int err;
+
+       of_property_read_u32(port->of_node, "rx-internal-delay-ps",
+                            &rx_delay_ps);
+
+       of_property_read_u32(port->of_node, "tx-internal-delay-ps",
+                            &tx_delay_ps);
+
+       err = lan969x_rgmii_get_clk_delay_sel(port, rx_delay_ps, &rx_clk_sel);
+       if (err)
+               return err;
+
+       err = lan969x_rgmii_get_clk_delay_sel(port, tx_delay_ps, &tx_clk_sel);
+       if (err)
+               return err;
+
+       /* Configure rx delay. */
+       spx5_rmw(HSIO_WRAP_DLL_CFG_DLL_RST_SET(0) |
+                HSIO_WRAP_DLL_CFG_DLL_ENA_SET(1) |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_ENA_SET(!!rx_delay_ps) |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_SEL_SET(rx_clk_sel),
+                HSIO_WRAP_DLL_CFG_DLL_RST |
+                HSIO_WRAP_DLL_CFG_DLL_ENA |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_ENA |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_SEL,
+                port->sparx5, HSIO_WRAP_DLL_CFG(idx, 0));
+
+       /* Configure tx delay. */
+       spx5_rmw(HSIO_WRAP_DLL_CFG_DLL_RST_SET(0) |
+                HSIO_WRAP_DLL_CFG_DLL_ENA_SET(1) |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_ENA_SET(!!tx_delay_ps) |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_SEL_SET(tx_clk_sel),
+                HSIO_WRAP_DLL_CFG_DLL_RST |
+                HSIO_WRAP_DLL_CFG_DLL_ENA |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_ENA |
+                HSIO_WRAP_DLL_CFG_DLL_CLK_SEL,
+                port->sparx5, HSIO_WRAP_DLL_CFG(idx, 1));
+
+       return 0;
+}
+
+/* Configure GPIO's to be used as RGMII interface. */
+static void lan969x_rgmii_gpio_config(struct sparx5_port *port)
+{
+       u32 idx = RGMII_PORT_IDX(port);
+
+       /* Enable the RGMII on the GPIOs. */
+       spx5_wr(HSIO_WRAP_XMII_CFG_GPIO_XMII_CFG_SET(1), port->sparx5,
+               HSIO_WRAP_XMII_CFG(!idx));
+}
+
+int lan969x_port_config_rgmii(struct sparx5_port *port,
+                             struct sparx5_port_config *conf)
+{
+       int err;
+
+       err = lan969x_rgmii_delay_config(port, conf);
+       if (err)
+               return err;
+
+       lan969x_rgmii_tx_clk_config(port, conf);
+       lan969x_rgmii_gpio_config(port);
+       lan969x_rgmii_port_device_config(port, conf);
+
+       return 0;
+}
index c58d7841638efee112cd7dfac0e927b6380303aa..3ae760da17e2b0b2ed58ae4e4e1d74064c8d9aeb 100644 (file)
@@ -324,6 +324,8 @@ struct sparx5_ops {
        irqreturn_t (*ptp_irq_handler)(int irq, void *args);
        int (*dsm_calendar_calc)(struct sparx5 *sparx5, u32 taxi,
                                 struct sparx5_calendar_data *data);
+       int (*port_config_rgmii)(struct sparx5_port *port,
+                                struct sparx5_port_config *conf);
 };
 
 struct sparx5_main_io_resource {
index 86d6c9e9ec7c1ba250ae0dfcbb2e9a001ec42908..04bc8fffaf961e014e3c64fe815f9900ac667026 100644 (file)
@@ -1012,6 +1012,12 @@ int sparx5_port_config(struct sparx5 *sparx5,
        if (err)
                return err;
 
+       if (rgmii) {
+               err = ops->port_config_rgmii(port, conf);
+               if (err)
+                       return err;
+       }
+
        /* high speed device is already configured */
        if (!rgmii && !high_speed_dev)
                sparx5_port_config_low_set(sparx5, port, conf);