]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-storage: Give better error message if user is missing UID/GID
authorTimo Sirainen <tss@iki.fi>
Fri, 20 Aug 2010 18:45:01 +0000 (19:45 +0100)
committerTimo Sirainen <tss@iki.fi>
Fri, 20 Aug 2010 18:45:01 +0000 (19:45 +0100)
src/lib-storage/mail-storage-service.c

index 794468e890348c1134107ea4221846238fbc8aba..92282004aaa5e6e4c1d9669172e5fd0cd60cf75c 100644 (file)
@@ -317,6 +317,9 @@ service_drop_privileges(const struct mail_user_settings *set,
                                dec2str(rset.uid));
                        return -1;
                }
+       } else if (rset.uid == (uid_t)-1) {
+               *error_r = "User is missing UID (see mail_uid setting)";
+               return -1;
        }
        if (*set->mail_gid != '\0') {
                if (!parse_gid(set->mail_gid, &rset.gid)) {
@@ -333,6 +336,9 @@ service_drop_privileges(const struct mail_user_settings *set,
                                dec2str(rset.gid));
                        return -1;
                }
+       } else if (rset.gid == (gid_t)-1) {
+               *error_r = "User is missing GID (see mail_gid setting)";
+               return -1;
        }
        if (*set->mail_privileged_group != '\0') {
                if (!parse_gid(set->mail_privileged_group, &rset.privileged_gid)) {