]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net/mlx4_core: Adjust allocation type for buddy->bits
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:07:58 +0000 (23:07 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Apr 2025 17:59:34 +0000 (10:59 -0700)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "unsigned long **", but the returned type will be
"long **". These are the same size allocation (pointer size) but the
types do not match. Adjust the allocation type to match the assignment.

Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250426060757.work.865-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/mr.c

index d7444782bfdd02863faa615a144c205b9b79666f..698a5d1f0d7e2620016bc832359ab9bcc5059a55 100644 (file)
@@ -106,7 +106,7 @@ static int mlx4_buddy_init(struct mlx4_buddy *buddy, int max_order)
        buddy->max_order = max_order;
        spin_lock_init(&buddy->lock);
 
-       buddy->bits = kcalloc(buddy->max_order + 1, sizeof(long *),
+       buddy->bits = kcalloc(buddy->max_order + 1, sizeof(*buddy->bits),
                              GFP_KERNEL);
        buddy->num_free = kcalloc(buddy->max_order + 1, sizeof(*buddy->num_free),
                                  GFP_KERNEL);