]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86/amd/pmc: fix leak in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 12 Mar 2025 08:31:57 +0000 (11:31 +0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 13 Mar 2025 13:00:33 +0000 (15:00 +0200)
Call pci_dev_put(rdev) before returning.

Fixes: 6ad1b2dc0f2a ("platform/x86/amd/pmc: Use managed APIs for mutex")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/65e2fffb-a1cb-4297-b725-661d6b790a05@stanley.mountain
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmc/pmc.c

index 84bc47009e5f94e1cf1af80cef4686a4fa8bd62b..d789d6cab79486c6f77c367e405a665030260552 100644 (file)
@@ -785,7 +785,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
 
        err = devm_mutex_init(dev->dev, &dev->lock);
        if (err)
-               return err;
+               goto err_pci_dev_put;
 
        /* Get num of IP blocks within the SoC */
        amd_pmc_get_ip_info(dev);