Bug 1371446 - Don't allow needinfo requests from the void

diff --git a/extensions/BugModal/web/bug_modal.css b/extensions/BugModal/web/bug_modal.css
index 666ee3f0dc0f3f1c10ee2067391b15399a35838b..9071c3d50aa1ca5e1225960814b031c8d769e534 100644 (file)
--- a/extensions/BugModal/web/bug_modal.css
+++ b/extensions/BugModal/web/bug_modal.css
@@ -88,6 +88,10 @@ select[multiple], .text_input, .yui-ac-input, input {
     box-shadow: 0 0 2px 2px #f88;
 }
 
+input:invalid {
+    box-shadow: 0 0 2px 2px #f88 !important;
+}
+
 a.activity-ref {
     color: #000;
 }

diff --git a/extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl b/extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
index 75ec90b89eaa17546305895da437acc04db42e1d..46083e108538e60d1ed75feccb64f20439fc540d 100644 (file)
--- a/extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
+++ b/extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
@@ -102,8 +102,12 @@ $(function() {
 
   function new_needinfo_changed(event) {
     if ($('#needinfo').is(':checked') && $('#needinfo_role').val() === 'other') {
+      $('#needinfo_from').prop('required', true);
       $('#needinfo_from').focus().select();
     }
+    else {
+      $('#needinfo_from').prop('required', false);
+    }
   }
 
   function existing_needinfo_changed(event) {