Use "use warnings" rather than -w on the #! line.

diff --git a/packaging/patch-update b/packaging/patch-update
index 46d9ff8fce5f465cc8ff20c0473ca08509ea97fc..30a29bce29fbc48aa664d49b7ec194ec965b1a58 100755 (executable)
--- a/packaging/patch-update
+++ b/packaging/patch-update
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This script is used to turn one or more of the "patch/*" branches
 # into one or more diffs in the "patches" directory.  Pass the option
 # --gen if you want generated files in the diffs.  Pass the name of
@@ -6,6 +6,7 @@
 # diffs.
 
 use strict;
+use warnings;
 use Getopt::Long;
 
 my $patches_dir = 'patches';

diff --git a/packaging/release-rsync b/packaging/release-rsync
index 957e89299116eb0bb8753b748e56484285a6b94c..71bb18e2451ea7e290c6a922386855f30aec108b 100755 (executable)
--- a/packaging/release-rsync
+++ b/packaging/release-rsync
@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 # This script expects the directory ~/samba-rsync-ftp to exist and to be a
 # copy of the /home/ftp/pub/rsync dir on samba.org.  When the script is done,

diff --git a/packaging/var-checker b/packaging/var-checker
index 445bea0e5c5ae2fe7513a03491c86b00c714a763..7c017252322debec5648515decd4900086927192 100755 (executable)
--- a/packaging/var-checker
+++ b/packaging/var-checker
@@ -1,9 +1,10 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This script checks the *.c files for extraneous "extern" variables,
 # for vars that are defined but not used, and for inconsistent array
 # sizes.  Run it from inside the main rsync directory.
 
 use strict;
+use warnings;
 
 my %add_syscall_c = map { $_ => 1 } qw( t_stub.c t_unsafe.c tls.c trimslash.c );
 my %add_compat_c = map { $_ => 1 } qw( t_stub.c tls.c trimslash.c wildtest.c );

diff --git a/support/git-set-file-times b/support/git-set-file-times
index 85d854e883988a699ddfef2c833bec00b1dce470..077ac0e0c989204e116737f9918b3b17a667361c 100755 (executable)
--- a/support/git-set-file-times
+++ b/support/git-set-file-times
@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 # Sets mtime and atime of files to the latest commit time in git.
 #

diff --git a/support/instant-rsyncd b/support/instant-rsyncd
index 6ab1e66ded8eb12005458be3477fe6e796f4549d..e9efb1abab6f1cd8f9504999548c61a918a38ff0 100755 (executable)
--- a/support/instant-rsyncd
+++ b/support/instant-rsyncd
@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/bin/bash
 
 # instant-rsyncd lets you quickly set up and start a simple, unprivileged rsync
 # daemon with a single module in the current directory.  I've found it
@@ -12,6 +12,8 @@
 # and once to log in to test the daemon.
 # -- Matt McCutchen <matt@mattmccutchen.net>
 
+set -e
+
 dir="$(pwd)"
 
 echo

diff --git a/support/mnt-excl b/support/mnt-excl
index 5514d96d2cd64334e283a84c94767ee8c18fa8f8..c6df5866407ba7885e09d0eb3ec7aee609233a4b 100755 (executable)
--- a/support/mnt-excl
+++ b/support/mnt-excl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This script takes a command-line arg of a source directory
 # that will be passed to rsync, and generates a set of excludes
 # that will exclude all mount points from the list.  This is
@@ -25,6 +25,7 @@
 # awk '{print $2}' /proc/mounts | rsync -f 'merge,/- -' host:/dir /dest/
 
 use strict;
+use warnings;
 use Cwd 'abs_path';
 
 my $file = '/proc/mounts';