xfs: pass alloc flags through to xfs_extent_busy_flush()

Source kernel commit: 6a2a9d776c4ae24a797e25eed2b9f7f33f756296

To avoid blocking in xfs_extent_busy_flush() when freeing extents
and the only busy extents are held by the current transaction, we
need to pass the XFS_ALLOC_FLAG_FREEING flag context all the way
into xfs_extent_busy_flush().

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>

diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
index a23341ae878746f56c15f4500ce11986ac9a2ff9..3e77d113fd00280cf1223d83555496657f9fa762 100644 (file)
--- a/libxfs/libxfs_priv.h
+++ b/libxfs/libxfs_priv.h
@@ -471,7 +471,7 @@ void __xfs_buf_mark_corrupt(struct xfs_buf *bp, xfs_failaddr_t fa);
        *(busy_gen) = __foo;                                    \
        false;                                                  \
 })
-#define xfs_extent_busy_flush(mp,pag,busy_gen)         ((void)(0))
+#define xfs_extent_busy_flush(mp,pag,busy_gen,alloc_flags)     ((void)(0))
 
 #define xfs_rotorstep                          1
 #define xfs_bmap_rtalloc(a)                    (-ENOSYS)

diff --git a/libxfs/xfs_alloc.c b/libxfs/xfs_alloc.c
index e5fd360cfff2703e599944aaa44fa49e4c5419e6..30a2fa125ef800fd37139b5960604c80f695958a 100644 (file)
--- a/libxfs/xfs_alloc.c
+++ b/libxfs/xfs_alloc.c
@@ -1532,7 +1532,8 @@ xfs_alloc_ag_vextent_lastblock(
  */
 STATIC int
 xfs_alloc_ag_vextent_near(
-       struct xfs_alloc_arg    *args)
+       struct xfs_alloc_arg    *args,
+       uint32_t                alloc_flags)
 {
        struct xfs_alloc_cur    acur = {};
        int                     error;          /* error code */
@@ -1608,7 +1609,7 @@ restart:
                if (acur.busy) {
                        trace_xfs_alloc_near_busy(args);
                        xfs_extent_busy_flush(args->mp, args->pag,
-                                             acur.busy_gen);
+                                             acur.busy_gen, alloc_flags);
                        goto restart;
                }
                trace_xfs_alloc_size_neither(args);
@@ -1631,21 +1632,22 @@ out:
  * and of the form k * prod + mod unless there's nothing that large.
  * Return the starting a.g. block, or NULLAGBLOCK if we can't do it.
  */
-STATIC int                             /* error */
+static int
 xfs_alloc_ag_vextent_size(
-       xfs_alloc_arg_t *args)          /* allocation argument structure */
+       struct xfs_alloc_arg    *args,
+       uint32_t                alloc_flags)
 {
-       struct xfs_agf  *agf = args->agbp->b_addr;
-       struct xfs_btree_cur *bno_cur;  /* cursor for bno btree */
-       struct xfs_btree_cur *cnt_cur;  /* cursor for cnt btree */
-       int             error;          /* error result */
-       xfs_agblock_t   fbno;           /* start of found freespace */
-       xfs_extlen_t    flen;           /* length of found freespace */
-       int             i;              /* temp status variable */
-       xfs_agblock_t   rbno;           /* returned block number */
-       xfs_extlen_t    rlen;           /* length of returned extent */
-       bool            busy;
-       unsigned        busy_gen;
+       struct xfs_agf          *agf = args->agbp->b_addr;
+       struct xfs_btree_cur    *bno_cur;
+       struct xfs_btree_cur    *cnt_cur;
+       xfs_agblock_t           fbno;           /* start of found freespace */
+       xfs_extlen_t            flen;           /* length of found freespace */
+       xfs_agblock_t           rbno;           /* returned block number */
+       xfs_extlen_t            rlen;           /* length of returned extent */
+       bool                    busy;
+       unsigned                busy_gen;
+       int                     error;
+       int                     i;
 
 restart:
        /*
@@ -1713,8 +1715,8 @@ restart:
                                xfs_btree_del_cursor(cnt_cur,
                                                     XFS_BTREE_NOERROR);
                                trace_xfs_alloc_size_busy(args);
-                               xfs_extent_busy_flush(args->mp,
-                                                       args->pag, busy_gen);
+                               xfs_extent_busy_flush(args->mp, args->pag,
+                                               busy_gen, alloc_flags);
                                goto restart;
                        }
                }
@@ -1798,7 +1800,8 @@ restart:
                if (busy) {
                        xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
                        trace_xfs_alloc_size_busy(args);
-                       xfs_extent_busy_flush(args->mp, args->pag, busy_gen);
+                       xfs_extent_busy_flush(args->mp, args->pag, busy_gen,
+                                       alloc_flags);
                        goto restart;
                }
                goto out_nominleft;
@@ -2568,7 +2571,7 @@ out:
 int                    /* error */
 xfs_alloc_fix_freelist(
        struct xfs_alloc_arg    *args,  /* allocation argument structure */
-       int                     flags)  /* XFS_ALLOC_FLAG_... */
+       uint32_t                alloc_flags)
 {
        struct xfs_mount        *mp = args->mp;
        struct xfs_perag        *pag = args->pag;
@@ -2584,7 +2587,7 @@ xfs_alloc_fix_freelist(
        ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
 
        if (!xfs_perag_initialised_agf(pag)) {
-               error = xfs_alloc_read_agf(pag, tp, flags, &agbp);
+               error = xfs_alloc_read_agf(pag, tp, alloc_flags, &agbp);
                if (error) {
                        /* Couldn't lock the AGF so skip this AG. */
                        if (error == -EAGAIN)
@@ -2600,13 +2603,13 @@ xfs_alloc_fix_freelist(
         */
        if (xfs_perag_prefers_metadata(pag) &&
            (args->datatype & XFS_ALLOC_USERDATA) &&
-           (flags & XFS_ALLOC_FLAG_TRYLOCK)) {
-               ASSERT(!(flags & XFS_ALLOC_FLAG_FREEING));
+           (alloc_flags & XFS_ALLOC_FLAG_TRYLOCK)) {
+               ASSERT(!(alloc_flags & XFS_ALLOC_FLAG_FREEING));
                goto out_agbp_relse;
        }
 
        need = xfs_alloc_min_freelist(mp, pag);
-       if (!xfs_alloc_space_available(args, need, flags |
+       if (!xfs_alloc_space_available(args, need, alloc_flags |
                        XFS_ALLOC_FLAG_CHECK))
                goto out_agbp_relse;
 
@@ -2615,7 +2618,7 @@ xfs_alloc_fix_freelist(
         * Can fail if we're not blocking on locks, and it's held.
         */
        if (!agbp) {
-               error = xfs_alloc_read_agf(pag, tp, flags, &agbp);
+               error = xfs_alloc_read_agf(pag, tp, alloc_flags, &agbp);
                if (error) {
                        /* Couldn't lock the AGF so skip this AG. */
                        if (error == -EAGAIN)
@@ -2630,7 +2633,7 @@ xfs_alloc_fix_freelist(
 
        /* If there isn't enough total space or single-extent, reject it. */
        need = xfs_alloc_min_freelist(mp, pag);
-       if (!xfs_alloc_space_available(args, need, flags))
+       if (!xfs_alloc_space_available(args, need, alloc_flags))
                goto out_agbp_relse;
 
 #ifdef DEBUG
@@ -2668,11 +2671,12 @@ xfs_alloc_fix_freelist(
         */
        memset(&targs, 0, sizeof(targs));
        /* struct copy below */
-       if (flags & XFS_ALLOC_FLAG_NORMAP)
+       if (alloc_flags & XFS_ALLOC_FLAG_NORMAP)
                targs.oinfo = XFS_RMAP_OINFO_SKIP_UPDATE;
        else
                targs.oinfo = XFS_RMAP_OINFO_AG;
-       while (!(flags & XFS_ALLOC_FLAG_NOSHRINK) && pag->pagf_flcount > need) {
+       while (!(alloc_flags & XFS_ALLOC_FLAG_NOSHRINK) &&
+                       pag->pagf_flcount > need) {
                error = xfs_alloc_get_freelist(pag, tp, agbp, &bno, 0);
                if (error)
                        goto out_agbp_relse;
@@ -2700,7 +2704,7 @@ xfs_alloc_fix_freelist(
                targs.resv = XFS_AG_RESV_AGFL;
 
                /* Allocate as many blocks as possible at once. */
-               error = xfs_alloc_ag_vextent_size(&targs);
+               error = xfs_alloc_ag_vextent_size(&targs, alloc_flags);
                if (error)
                        goto out_agflbp_relse;
 
@@ -2710,7 +2714,7 @@ xfs_alloc_fix_freelist(
                 * on a completely full ag.
                 */
                if (targs.agbno == NULLAGBLOCK) {
-                       if (flags & XFS_ALLOC_FLAG_FREEING)
+                       if (alloc_flags & XFS_ALLOC_FLAG_FREEING)
                                break;
                        goto out_agflbp_relse;
                }
@@ -3226,7 +3230,7 @@ xfs_alloc_vextent_check_args(
 static int
 xfs_alloc_vextent_prepare_ag(
        struct xfs_alloc_arg    *args,
-       uint32_t                flags)
+       uint32_t                alloc_flags)
 {
        bool                    need_pag = !args->pag;
        int                     error;
@@ -3235,7 +3239,7 @@ xfs_alloc_vextent_prepare_ag(
                args->pag = xfs_perag_get(args->mp, args->agno);
 
        args->agbp = NULL;
-       error = xfs_alloc_fix_freelist(args, flags);
+       error = xfs_alloc_fix_freelist(args, alloc_flags);
        if (error) {
                trace_xfs_alloc_vextent_nofix(args);
                if (need_pag)
@@ -3357,6 +3361,7 @@ xfs_alloc_vextent_this_ag(
 {
        struct xfs_mount        *mp = args->mp;
        xfs_agnumber_t          minimum_agno;
+       uint32_t                alloc_flags = 0;
        int                     error;
 
        ASSERT(args->pag != NULL);
@@ -3375,9 +3380,9 @@ xfs_alloc_vextent_this_ag(
                return error;
        }
 
-       error = xfs_alloc_vextent_prepare_ag(args, 0);
+       error = xfs_alloc_vextent_prepare_ag(args, alloc_flags);
        if (!error && args->agbp)
-               error = xfs_alloc_ag_vextent_size(args);
+               error = xfs_alloc_ag_vextent_size(args, alloc_flags);
 
        return xfs_alloc_vextent_finish(args, minimum_agno, error, false);
 }
@@ -3406,20 +3411,20 @@ xfs_alloc_vextent_iterate_ags(
        xfs_agnumber_t          minimum_agno,
        xfs_agnumber_t          start_agno,
        xfs_agblock_t           target_agbno,
-       uint32_t                flags)
+       uint32_t                alloc_flags)
 {
        struct xfs_mount        *mp = args->mp;
        xfs_agnumber_t          restart_agno = minimum_agno;
        xfs_agnumber_t          agno;
        int                     error = 0;
 
-       if (flags & XFS_ALLOC_FLAG_TRYLOCK)
+       if (alloc_flags & XFS_ALLOC_FLAG_TRYLOCK)
                restart_agno = 0;
 restart:
        for_each_perag_wrap_range(mp, start_agno, restart_agno,
                        mp->m_sb.sb_agcount, agno, args->pag) {
                args->agno = agno;
-               error = xfs_alloc_vextent_prepare_ag(args, flags);
+               error = xfs_alloc_vextent_prepare_ag(args, alloc_flags);
                if (error)
                        break;
                if (!args->agbp) {
@@ -3433,10 +3438,10 @@ restart:
                 */
                if (args->agno == start_agno && target_agbno) {
                        args->agbno = target_agbno;
-                       error = xfs_alloc_ag_vextent_near(args);
+                       error = xfs_alloc_ag_vextent_near(args, alloc_flags);
                } else {
                        args->agbno = 0;
-                       error = xfs_alloc_ag_vextent_size(args);
+                       error = xfs_alloc_ag_vextent_size(args, alloc_flags);
                }
                break;
        }
@@ -3453,8 +3458,8 @@ restart:
         * constraining flags by the caller, drop them and retry the allocation
         * without any constraints being set.
         */
-       if (flags) {
-               flags = 0;
+       if (alloc_flags & XFS_ALLOC_FLAG_TRYLOCK) {
+               alloc_flags &= ~XFS_ALLOC_FLAG_TRYLOCK;
                restart_agno = minimum_agno;
                goto restart;
        }
@@ -3482,6 +3487,7 @@ xfs_alloc_vextent_start_ag(
        xfs_agnumber_t          start_agno;
        xfs_agnumber_t          rotorstep = xfs_rotorstep;
        bool                    bump_rotor = false;
+       uint32_t                alloc_flags = XFS_ALLOC_FLAG_TRYLOCK;
        int                     error;
 
        ASSERT(args->pag == NULL);
@@ -3508,7 +3514,7 @@ xfs_alloc_vextent_start_ag(
 
        start_agno = max(minimum_agno, XFS_FSB_TO_AGNO(mp, target));
        error = xfs_alloc_vextent_iterate_ags(args, minimum_agno, start_agno,
-                       XFS_FSB_TO_AGBNO(mp, target), XFS_ALLOC_FLAG_TRYLOCK);
+                       XFS_FSB_TO_AGBNO(mp, target), alloc_flags);
 
        if (bump_rotor) {
                if (args->agno == start_agno)
@@ -3535,6 +3541,7 @@ xfs_alloc_vextent_first_ag(
        struct xfs_mount        *mp = args->mp;
        xfs_agnumber_t          minimum_agno;
        xfs_agnumber_t          start_agno;
+       uint32_t                alloc_flags = XFS_ALLOC_FLAG_TRYLOCK;
        int                     error;
 
        ASSERT(args->pag == NULL);
@@ -3553,7 +3560,7 @@ xfs_alloc_vextent_first_ag(
 
        start_agno = max(minimum_agno, XFS_FSB_TO_AGNO(mp, target));
        error = xfs_alloc_vextent_iterate_ags(args, minimum_agno, start_agno,
-                       XFS_FSB_TO_AGBNO(mp, target), 0);
+                       XFS_FSB_TO_AGBNO(mp, target), alloc_flags);
        return xfs_alloc_vextent_finish(args, minimum_agno, error, true);
 }
 
@@ -3606,6 +3613,7 @@ xfs_alloc_vextent_near_bno(
        struct xfs_mount        *mp = args->mp;
        xfs_agnumber_t          minimum_agno;
        bool                    needs_perag = args->pag == NULL;
+       uint32_t                alloc_flags = 0;
        int                     error;
 
        if (!needs_perag)
@@ -3626,9 +3634,9 @@ xfs_alloc_vextent_near_bno(
        if (needs_perag)
                args->pag = xfs_perag_grab(mp, args->agno);
 
-       error = xfs_alloc_vextent_prepare_ag(args, 0);
+       error = xfs_alloc_vextent_prepare_ag(args, alloc_flags);
        if (!error && args->agbp)
-               error = xfs_alloc_ag_vextent_near(args);
+               error = xfs_alloc_ag_vextent_near(args, alloc_flags);
 
        return xfs_alloc_vextent_finish(args, minimum_agno, error, needs_perag);
 }

diff --git a/libxfs/xfs_alloc.h b/libxfs/xfs_alloc.h
index a3e519577e09758cdad0173a78c1ce0d3478db34..7a10714171ca8b61fa7edbe13679fdfa69decf38 100644 (file)
--- a/libxfs/xfs_alloc.h
+++ b/libxfs/xfs_alloc.h
@@ -195,7 +195,7 @@ int xfs_alloc_read_agfl(struct xfs_perag *pag, struct xfs_trans *tp,
                struct xfs_buf **bpp);
 int xfs_free_agfl_block(struct xfs_trans *, xfs_agnumber_t, xfs_agblock_t,
                        struct xfs_buf *, struct xfs_owner_info *);
-int xfs_alloc_fix_freelist(struct xfs_alloc_arg *args, int flags);
+int xfs_alloc_fix_freelist(struct xfs_alloc_arg *args, uint32_t alloc_flags);
 int xfs_free_extent_fix_freelist(struct xfs_trans *tp, struct xfs_perag *pag,
                struct xfs_buf **agbp);