]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: amd: acp: Fix leak in acp_pci_probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 14 Mar 2025 10:11:43 +0000 (13:11 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 16 Mar 2025 23:33:41 +0000 (23:33 +0000)
There needs to be some cleanup on this error path.  We can't just
return directly.

Fixes: aaf7a668bb38 ("ASoC: amd: acp: Add new interrupt handle callbacks in acp_common_hw_ops")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/3dad80cb-e177-45aa-97ac-df9c98a47d94@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-pci.c

index 9322379cb36fcc36ff4623afe2d0af3c0b78a1bc..123524f90d6c4dc3639e5e92eb79385ec358fefc 100644 (file)
@@ -183,7 +183,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
                               IRQF_SHARED, "ACP_I2S_IRQ", chip);
        if (ret) {
                dev_err(&pci->dev, "ACP I2S IRQ request failed %d\n", ret);
-               return ret;
+               goto de_init;
        }
 
        check_acp_config(pci, chip);