scripts: Add check for unsafe files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/Makefile.am b/Makefile.am
index 51d1b936da370f6ce8a6a597ce51ec861a716d4c..b8ec077fc815fc518e7cc47dc5da8672d2dd7f39 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -556,6 +556,7 @@ libpakfire_preload_la_LIBADD = \
 dist_scripts_SCRIPTS = \
        src/scripts/check-buildroot \
        src/scripts/check-include \
+       src/scripts/check-unsafe-files \
        src/scripts/cleanup \
        src/scripts/compress-man-pages \
        src/scripts/find-common \

diff --git a/src/libpakfire/build.c b/src/libpakfire/build.c
index d585e2e0ca8cb8395d934599b8a9b1b52673592e..ef846171e10cc728d1cb57c2be0ee3fc35f373b9 100644 (file)
--- a/src/libpakfire/build.c
+++ b/src/libpakfire/build.c
@@ -339,6 +339,7 @@ ERROR:
 
 static const char* post_build_scripts[] = {
        "remove-static-libs",
+       "check-unsafe-files",
        "check-buildroot",
        "check-include",
        "compress-man-pages",

diff --git a/src/scripts/check-unsafe-files b/src/scripts/check-unsafe-files
new file mode 100644 (file)
index 0000000..7b74264
--- /dev/null
+++ b/src/scripts/check-unsafe-files
@@ -0,0 +1,67 @@
+#!/bin/bash
+###############################################################################
+#                                                                             #
+# Pakfire - The IPFire package management system                              #
+# Copyright (C) 2021 Pakfire development team                                 #
+#                                                                             #
+# This program is free software: you can redistribute it and/or modify        #
+# it under the terms of the GNU General Public License as published by        #
+# the Free Software Foundation, either version 3 of the License, or           #
+# (at your option) any later version.                                         #
+#                                                                             #
+# This program is distributed in the hope that it will be useful,             #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
+# GNU General Public License for more details.                                #
+#                                                                             #
+# You should have received a copy of the GNU General Public License           #
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
+#                                                                             #
+###############################################################################
+
+error() {
+       echo "${0#/}: $@" >&2
+}
+
+main() {
+       local buildroot="${1}"
+       shift
+
+       # Check if BUILDROOT exists
+       if [ ! -d "${buildroot}" ]; then
+               error "BUILDROOT does not exist"
+               return 1
+       fi
+
+       # Find all files that are world-writable
+       local -a files=(
+               $(find "${buildroot}" -type f -perm -2 | sort)
+       )
+       if [ "${#files[@]}" -gt 0 ]; then
+               error "SECURITY NOTICE: The following files are world-writable:"
+               local file
+               for file in ${files[@]}; do
+                       error "  ${file/${buildroot}/}"
+               done
+
+               return 1
+       fi
+
+       # Find all files that use set*id and are world-writable
+       files=(
+               $(find "${buildroot}" -type f \( -perm -2002 -or -perm -4002 \) | sort)
+       )
+       if [ "${#files[@]}" -gt 0 ]; then
+               error "SECURITY NOTICE: The following files are world-writable:"
+               local file
+               for file in ${files[@]}; do
+                       error "  ${file/${buildroot}/}"
+               done
+
+               return 1
+       fi
+
+       return 0
+}
+
+main "$@" || exit $?