]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests/mm: fix thuge-gen test name uniqueness
authorMark Brown <broonie@kernel.org>
Tue, 4 Feb 2025 22:53:43 +0000 (22:53 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 05:06:03 +0000 (22:06 -0700)
The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
variety of sizes but always report the result of their test with the same
name, meaning that automated sysetms running the tests are unable to
distinguish between the various tests.  Add the supplied sizes to the
logged test names to distinguish between runs.

My test automation was getting pretty confused about what was going on
- the test names are a pretty important external interface.

Link: https://lkml.kernel.org/r/20250204-kselftest-mm-fix-dups-v1-1-6afe417ef4bb@kernel.org
Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")
Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Dev Jain <dev.jain@arm.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/mm/thuge-gen.c

index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644 (file)
@@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
 
        show(size);
        ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-                        "%s mmap\n", __func__);
+                        "%s mmap %lu\n", __func__, size);
 
        if (munmap(map, size * NUM_PAGES))
                ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
@@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
 
        show(size);
        ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-                        "%s: mmap\n", __func__);
+                        "%s: mmap %lu\n", __func__, size);
        if (shmdt(map))
                ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
 }