]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86/amd: hfi: Remove redundant assignment to .owner
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sat, 11 Oct 2025 06:38:37 +0000 (14:38 +0800)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 15 Oct 2025 08:38:28 +0000 (11:38 +0300)
The coccicheck tool reports the following warning for this driver:

./hfi.c:509:3-8: No need to set .owner here. The core will do it.

The manual assignment of .owner = THIS_MODULE; in the platform_driver
struct is redundant. The platform_driver_register() function, which is
called to register the driver, is a macro that automatically sets the
driver's owner to THIS_MODULE.

The driver core handles this assignment internally, making the explicit
initialization in the struct definition unnecessary. Remove the
unnecessary line.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/20251011063837.2318535-3-visitorckw@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/hfi/hfi.c

index 5d5d2cf23a7501fddac7e1a635c2b94f3cd5d4db..83863a5e0fbc6f43c383a1d47d035c9d7015739f 100644 (file)
@@ -505,7 +505,6 @@ static int amd_hfi_probe(struct platform_device *pdev)
 static struct platform_driver amd_hfi_driver = {
        .driver = {
                .name = AMD_HFI_DRIVER,
-               .owner = THIS_MODULE,
                .pm = &amd_hfi_pm_ops,
                .acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
        },