]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ublk: don't pass ublk_queue to __ublk_fail_req()
authorCaleb Sander Mateos <csander@purestorage.com>
Thu, 18 Sep 2025 01:49:39 +0000 (19:49 -0600)
committerJens Axboe <axboe@kernel.dk>
Sat, 20 Sep 2025 12:36:27 +0000 (06:36 -0600)
__ublk_fail_req() only uses the ublk_queue to get the ublk_device, which
its caller already has. So just pass the ublk_device directly.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index bac16ec3151ced98cc82b87eea8080c9350b4e30..4cb023d26593ae28b90829284eb7e311cf99a8bd 100644 (file)
@@ -1708,12 +1708,12 @@ static int ublk_ch_mmap(struct file *filp, struct vm_area_struct *vma)
        return remap_pfn_range(vma, vma->vm_start, pfn, sz, vma->vm_page_prot);
 }
 
-static void __ublk_fail_req(struct ublk_queue *ubq, struct ublk_io *io,
+static void __ublk_fail_req(struct ublk_device *ub, struct ublk_io *io,
                struct request *req)
 {
        WARN_ON_ONCE(io->flags & UBLK_IO_FLAG_ACTIVE);
 
-       if (ublk_nosrv_should_reissue_outstanding(ubq->dev))
+       if (ublk_nosrv_should_reissue_outstanding(ub))
                blk_mq_requeue_request(req, false);
        else {
                io->res = -EIO;
@@ -1737,7 +1737,7 @@ static void ublk_abort_queue(struct ublk_device *ub, struct ublk_queue *ubq)
                struct ublk_io *io = &ubq->ios[i];
 
                if (io->flags & UBLK_IO_FLAG_OWNED_BY_SRV)
-                       __ublk_fail_req(ubq, io, io->req);
+                       __ublk_fail_req(ub, io, io->req);
        }
 }