]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Do not assign nil values in ACLFilledChecklist::syncAle() (#240)
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Fri, 6 Jul 2018 12:34:30 +0000 (12:34 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Mon, 9 Jul 2018 04:35:02 +0000 (16:35 +1200)
Being explicit about nil parameters protects (future) code from
dereferencing them.

src/acl/FilledChecklist.cc

index b5ce7d21ac38958ce72e5c2ad1de349d37c0e5c3..27c49a8111405f53c26761f1289264e6ed8a9647 100644 (file)
@@ -132,11 +132,11 @@ ACLFilledChecklist::syncAle(HttpRequest *adaptedRequest, const char *logUri) con
 {
     if (!al)
         return;
-    if (!al->adapted_request) {
+    if (adaptedRequest && !al->adapted_request) {
         al->adapted_request = adaptedRequest;
         HTTPMSGLOCK(al->adapted_request);
     }
-    if (al->url.isEmpty())
+    if (logUri && al->url.isEmpty())
         al->url = logUri;
 }