]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drbd: init queue_limits->max_hw_wzeroes_unmap_sectors parameter
authorZhang Yi <yi.zhang@huawei.com>
Wed, 10 Sep 2025 11:11:07 +0000 (19:11 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 17 Sep 2025 14:20:49 +0000 (08:20 -0600)
The parameter max_hw_wzeroes_unmap_sectors in queue_limits should be
equal to max_write_zeroes_sectors if it is set to a non-zero value.
However, when the backend bdev is specified, this parameter is
initialized to UINT_MAX during the call to blk_set_stacking_limits(),
while only max_write_zeroes_sectors is adjusted. Therefore, this
discrepancy triggers a value check failure in blk_validate_limits().

Since the drvd driver doesn't yet support unmap write zeroes, so fix
this failure by explicitly setting max_hw_wzeroes_unmap_sectors to
zero.

Fixes: 0c40d7cb5ef3 ("block: introduce max_{hw|user}_wzeroes_unmap_sectors to queue limits")
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_nl.c

index e09930c2b22627df8453733684dd4a9460aee7de..91f3b8afb63ce620c4123a5d4e3fd99416a71d7f 100644 (file)
@@ -1330,6 +1330,7 @@ void drbd_reconsider_queue_parameters(struct drbd_device *device,
                lim.max_write_zeroes_sectors = DRBD_MAX_BBIO_SECTORS;
        else
                lim.max_write_zeroes_sectors = 0;
+       lim.max_hw_wzeroes_unmap_sectors = 0;
 
        if ((lim.discard_granularity >> SECTOR_SHIFT) >
            lim.max_hw_discard_sectors) {