]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging: sm750fb: remove unnecessary volatile qualifiers
authorYiming Qian <qianym1996@gmail.com>
Tue, 9 Sep 2025 06:01:29 +0000 (14:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Sep 2025 13:54:01 +0000 (15:54 +0200)
The use of 'volatile' for memory-mapped I/O pointers is discouraged
in the Linux kernel as per
Documentation/process/volatile-considered-harmful.rst.

This patch removes the unnecessary 'volatile' qualifiers from the
lynx_accel struct members, improving code quality and maintainability.

Signed-off-by: Yiming Qian <qianym1996@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20250909060130.12919-2-qianym1996@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/sm750.h

index d7f40efe3a2ce4580a03865386de1ed724aec38c..41f1fb3901740822f7aca90bc1975d5b70ddd752 100644 (file)
@@ -50,9 +50,9 @@ struct init_status {
 
 struct lynx_accel {
        /* base virtual address of DPR registers */
-       volatile unsigned char __iomem *dprBase;
+       unsigned char __iomem *dprBase;
        /* base virtual address of de data port */
-       volatile unsigned char __iomem *dpPortBase;
+       unsigned char __iomem *dpPortBase;
 
        /* function pointers */
        void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor {
        char __iomem *vstart;
        int offset;
        /* mmio addr of hw cursor */
-       volatile char __iomem *mmio;
+       char __iomem *mmio;
 };
 
 struct lynxfb_crtc {