Check library name rather than member name when rereading symbols.

On Darwin, we have lots of complaints being emitted when restarting
a program:

    (gdb) start
    `a-except.o' has disappeared; keeping its symbols.
    `unwind-dw2.o' has disappeared; keeping its symbols.
    `s-except.o' has disappeared; keeping its symbols.
    `s-traceb.o' has disappeared; keeping its symbols.

These object files are part of the GNAT runtime, and were never available.
The warning comes from the fact that we're checking whether the .o files
in the GNAT shared runtime have changed whereas we should be checking
whether the GNAT shared library itself has changed.

This patch implements this.  Although it is really only useful on a platform
such as Darwin (debug info stored in .o files), we believe that this is
the right thing to do in general.  This change should be a noop for all
the other platforms in any case.

gdb/ChangeLog (from Tristan Gingold & Pedro Alves):

        * symfile.c (reread_symbols): Also search for file in libraries.
        Update comment.

Tested on x86_64-darwin and x86_64-linux.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 33ead66330949c35c504c0d0768189c85d192b5e..b84aa5d6146ddd451186915db97a94ec45bcdfcc 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-04-27  Joel Brobecker  <brobecker@adacore.com>
+
+       * symfile.c (reread_symbols): Also search for file in libraries.
+       Update comment.
+
 2010-04-27  Joel Brobecker  <brobecker@adacore.com>
 
        * configure.tgt: Treat x86-lynxos targets as x86 bareboard targets

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 4f70445c6015cc32363a745ccd68e74b912301b6..0528488c3cff73f0f6cd9604eca8f6305b205d47 100644 (file)
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2290,14 +2290,13 @@ reread_symbols (void)
       if (objfile->separate_debug_objfile_backlink)
        continue;
 
-#ifdef DEPRECATED_IBM6000_TARGET
-      /* If this object is from a shared library, then you should
-        stat on the library name, not member name. */
-
+      /* If this object is from an archive (what you usually create with
+        `ar', often called a `static library' on most systems, though
+        a `shared library' on AIX is also an archive), then you should
+        stat on the archive name, not member name.  */
       if (objfile->obfd->my_archive)
        res = stat (objfile->obfd->my_archive->filename, &new_statbuf);
       else
-#endif
        res = stat (objfile->name, &new_statbuf);
       if (res != 0)
        {