]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mac80211: apply mcast rate only if interface is up
authorJohannes Berg <johannes.berg@intel.com>
Wed, 15 May 2024 11:34:10 +0000 (13:34 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 29 May 2024 13:24:52 +0000 (15:24 +0200)
If the interface isn't enabled, don't apply multicast
rate changes immediately.

Reported-by: syzbot+de87c09cc7b964ea2e23@syzkaller.appspotmail.com
Link: https://msgid.link/20240515133410.d6cffe5756cc.I47b624a317e62bdb4609ff7fa79403c0c444d32d@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/cfg.c

index b08e5d7687e3fcfb855b3db7ea916491d5c10c1b..99abbb9e8477bdc5c8cf56af92b257e956fbcbaa 100644 (file)
@@ -2958,8 +2958,9 @@ static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device *dev,
        memcpy(sdata->vif.bss_conf.mcast_rate, rate,
               sizeof(int) * NUM_NL80211_BANDS);
 
-       ieee80211_link_info_change_notify(sdata, &sdata->deflink,
-                                         BSS_CHANGED_MCAST_RATE);
+       if (ieee80211_sdata_running(sdata))
+               ieee80211_link_info_change_notify(sdata, &sdata->deflink,
+                                                 BSS_CHANGED_MCAST_RATE);
 
        return 0;
 }